[Piglit] [PATCH 5/5] gl-1.0: use default window size to fix Windows run

[Jose Fonseca]

Brian,

Series looks alright, but it looks to me this is a pervasive issue, and not just a few isolated cases:

 piglit $ git grep config.window_width | wc -l
 461

So I wonder if there isn't a more definite solution. For example, could we simply modify tests/util/... helper code to sanitize window_width/height on Windows before the window is created?

Also, I think this is probably just a glut limitation, not a Windows intrinsic limitation. If we switched to waffle we could force the window to be any size by mimicking what mesa/src/gallium/state_trackers/wgl/stw_ext_pbuffer.c does.

Jose 

----- Original Message -----
> ---
>  tests/spec/gl-1.0/edgeflag-quads.c |    2 --
>  tests/spec/gl-1.0/edgeflag.c       |    2 --
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/spec/gl-1.0/edgeflag-quads.c
> b/tests/spec/gl-1.0/edgeflag-quads.c
> index 12ad289..702513d 100644
> --- a/tests/spec/gl-1.0/edgeflag-quads.c
> +++ b/tests/spec/gl-1.0/edgeflag-quads.c
> @@ -36,8 +36,6 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>  
>  	config.supports_gl_compat_version = 10;
>  
> -	config.window_width = 32;
> -	config.window_height = 32;
>  	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB |
>  	PIGLIT_GL_VISUAL_ALPHA;
>  
>  PIGLIT_GL_TEST_CONFIG_END
> diff --git a/tests/spec/gl-1.0/edgeflag.c b/tests/spec/gl-1.0/edgeflag.c
> index aa1cb6a..15b0aff 100644
> --- a/tests/spec/gl-1.0/edgeflag.c
> +++ b/tests/spec/gl-1.0/edgeflag.c
> @@ -32,8 +32,6 @@ PIGLIT_GL_TEST_CONFIG_BEGIN
>  
>  	config.supports_gl_compat_version = 10;
>  
> -	config.window_width = 32;
> -	config.window_height = 32;
>  	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB |
>  	PIGLIT_GL_VISUAL_ALPHA;
>  
>  PIGLIT_GL_TEST_CONFIG_END
> --
> 1.7.3.4
> 
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>