[Piglit] [PATCH 5/5] gl-1.0: use default window size to fix Windows run

Jose Fonseca jfonseca at vmware.com
Sat Apr 6 14:01:18 PDT 2013

----- Original Message -----
> On 04/06/2013 03:21 AM, Jose Fonseca wrote:
> > Brian,
> >
> > Series looks alright, but it looks to me this is a pervasive issue, and not
> > just a few isolated cases:
> >
> >   piglit $ git grep config.window_width | wc -l
> >   461
> >
> > So I wonder if there isn't a more definite solution. For example, could we
> > simply modify tests/util/... helper code to sanitize window_width/height
> > on Windows before the window is created?
> In some cases, we can't just change the window size without breaking
> things.  Ex: draw-pixels.c needed a glPixelStore() change to work with
> different sizes.  Others which probe hard-coded pixel positions can
> fail with different sizes.

Understood. But given that would be no more broken than it is now, and that all those cases which would work with a mere window resize (and if my memory serves there seem to be quite a lot that fit into that category) would just work, it seems it a worthwhile thing to do.

> > Also, I think this is probably just a glut limitation, not a Windows
> > intrinsic limitation. If we switched to waffle we could force the window
> > to be any size by mimicking what
> > mesa/src/gallium/state_trackers/wgl/stw_ext_pbuffer.c does.
> Unfortunately, I don't think waffle has any WGL support yet.



More information about the Piglit mailing list