[Piglit] [PATCH] Add test for concurrent shader compiler use. v3

Eric Anholt eric at anholt.net
Mon Apr 22 09:39:02 PDT 2013


Tom Stellard <tom at stellard.net> writes:

> From: Mathias Froehlich <Mathias.Froehlich at web.de>
>
> Add a test that creates two contexts and concurrently
> compiles shader programs to test race conditions of
> the shader compiler.
>
> v3: (Tom Stellard)
>   - Report pass at the end of the tests
>   - Add as a concurrent test
>
> Signed-off-by: Mathias Froehlich <Mathias.Froehlich at web.de>
> Reviewed-by: Tom Stellard <thomas.stellard at amd.com>


> +
> +		/* Ok, not nice but should be safe due to all threads working
> +		   on the same type of context. */

We format our comments as:

+		/* Ok, not nice but should be safe due to all threads working
+		 * on the same type of context.
+		 */

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130422/ef61a75a/attachment.pgp>


More information about the Piglit mailing list