[Piglit] [PATCH 4/7] html: Rework colgroup generation.

Dylan Baker baker.dylan.c at gmail.com
Thu Apr 25 17:02:22 PDT 2013


From: Kenneth Graunke <kenneth at whitecape.org>

There's no need to specify width="50pt" on every <col/>; we can easily
specify a width for all but the first column with CSS3.

At that point, using a template file that contains only <col/> seems
absurd; just repeat that the right number of times in the python code.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 piglit-summary-html.py       | 3 +--
 templates/index.css          | 4 ++++
 templates/index_testrun.html | 1 -
 3 files changed, 5 insertions(+), 3 deletions(-)
 delete mode 100644 templates/index_testrun.html

diff --git a/piglit-summary-html.py b/piglit-summary-html.py
index d2fe5ee..0f3e049 100755
--- a/piglit-summary-html.py
+++ b/piglit-summary-html.py
@@ -62,7 +62,6 @@ ResultListItem = readfile(os.path.join(templatedir, 'result_listitem.html'))
 ResultMString = readfile(os.path.join(templatedir, 'result_mstring.html'))
 
 Index = readfile(os.path.join(templatedir, 'index.html'))
-IndexTestrun = readfile(os.path.join(templatedir, 'index_testrun.html'))
 IndexTestrunB = readfile(os.path.join(templatedir, 'index_testrunb.html'))
 IndexTestrunBHref = readfile(os.path.join(templatedir, 'index_testrunb_href.html'))
 IndexGroup = readfile(os.path.join(templatedir, 'index_group.html'))
@@ -232,7 +231,7 @@ results is an array containing the top-level results dictionarys.
 			return IndexTestrunB % tr.__dict__
 
 	group = buildGroupSummary(0, summary.root, showcurrent)
-	testruns = "".join([IndexTestrun % tr.__dict__ for tr in summary.testruns])
+	testruns = '<col/>' * len(summary.testruns)
 	testrunsb = "".join([testrunb(tr) for tr in summary.testruns])
 
 	tolist = SummaryPages.keys()
diff --git a/templates/index.css b/templates/index.css
index 0e48e1c..27128e4 100644
--- a/templates/index.css
+++ b/templates/index.css
@@ -7,6 +7,10 @@ table {
 	width: 100%;
 }
 
+col:not(:first-child) {
+	width: 50pt;
+}
+
 tr {
 	padding: 4pt;
 }
diff --git a/templates/index_testrun.html b/templates/index_testrun.html
deleted file mode 100644
index 1dc68ff..0000000
--- a/templates/index_testrun.html
+++ /dev/null
@@ -1 +0,0 @@
-<col width="50pt" />
-- 
1.8.1.4



More information about the Piglit mailing list