[Piglit] glx-multithread-shader-compile hung

[Mathias Fröhlich]

On Wednesday, July 31, 2013 08:16:25 Jose Fonseca wrote:
> FYI, I twice now got deadlock on glx-multithread-shader-compile on my
> continuous testing of Mesa:
> 
>   ...
>   [Sat Jul 20 01:18:20 2013] ::  running ::
> glx/glx-multithread-shader-compile  <-- last piglit message Build timed out
> (after 120 minutes). Marking the build as failed.   <-- Jenkins message
> 
> I'm going to disable the test on my custom test list.  But I believe that if
> we're going to add multi-threaded tests to piglit, then we should have a
> per-test timeout (ie, after a threshold time like 5min the framework should
> kill the process and mark the test as failed).  Otherwise these race
> condition tests do more harm than good -- as they prevent all other tests
> from running.

A timeout looks perfect.
May be the attached patch helps to keep this test in mind :-)

Mathias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multithread-timeout.diff
Type: text/x-patch
Size: 1856 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130801/a1bb2ee6/attachment-0001.bin>