[Piglit] [PATCH] glsl-1.50 compiler: Test that gl_FragCoord redeclaration recognized by compiler

[Ian Romanick]

On 08/07/2013 01:56 PM, Steve Miller wrote:
> Test that arb_fragment_coord_conventions switched on in GLSL 1.50 by default
>
> ---
>   .../layout-qualifier-basic-check.frag              | 28 ++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
>   create mode 100644 tests/spec/glsl-1.50/compiler/fragment_coord_conventions/layout-qualifier-basic-check.frag
>
> diff --git a/tests/spec/glsl-1.50/compiler/fragment_coord_conventions/layout-qualifier-basic-check.frag b/tests/spec/glsl-1.50/compiler/fragment_coord_conventions/layout-qualifier-basic-check.frag
> new file mode 100644
> index 0000000..570d477
> --- /dev/null
> +++ b/tests/spec/glsl-1.50/compiler/fragment_coord_conventions/layout-qualifier-basic-check.frag
> @@ -0,0 +1,28 @@
> +// [config]
> +// expect_result: pass
> +// glsl_version: 1.50
> +// check_link: false
> +// [end config]
> +/*
> +* Section 4.3.8.1 (Input Layout Qualifiers) of the GLSL 1.50 spec says:
> +*  Fragment shaders can have an input layout only for redeclaring the
> +*  built-in variable gl_FragCoord (see section 7.2 Fragment Shader Special
> +*  Variables). The layout qualifier identifiers for gl_FragCoord are
> +*      layout-qualifier-id:
> +*          origin_upper_left
> +*          pixel_center_integer
> +* This test is just a check to make sure the arb_fragment_coord_conventions
> +* extension is switched on in core compiler.
> +*
> +*/

This formatting is a little off from the usual way.  You should pick one 
kind of comment (either /* */ or //) and stick with it.  If you use /* 
*/, the second and following lines should have a space at the beginning 
so that the * characters line up.

The block of quoted text gets four extra space of indentation, and it 
gets, well, quoted. :)

I would have formatted this as below.  I had to manually re-word-wrap 
the text so that my e-mail program wouldn't do something too stupid.

/* Section 4.3.8.1 (Input Layout Qualifiers) of the GLSL 1.50 spec says:
  *
  *     "Fragment shaders can have an input layout only for redeclaring
  *     the built-in variable gl_FragCoord (see section 7.2 Fragment
  *     Shader Special Variables). The layout qualifier identifiers for
  *     gl_FragCoord are
  *
  *          layout-qualifier-id:
  *              origin_upper_left
  *              pixel_center_integer"
  *
  * This test is just a check to make sure the
  * arb_fragment_coord_conventions extension is switched on in core
  * compiler.
  */

> +
> +#version 150
> +
> +layout(origin_upper_left, pixel_center_integer) in vec4 gl_FragCoord;
> +
> +void main() {
> +
> +     gl_FragColor = vec4 (gl_FragCoord.x, gl_FragCoord.y,
> +     		    	 gl_FragCoord.z, gl_FragCoord.z);
> +

1. Opening { of a function goes on it's own line.

2. Spurious blank lines.

3. Mixed tabs and spaces for indentation.

> +}
> \ No newline at end of file

And fix that. :)