[Piglit] [PATCH 1/2] gles3: Test TEXTURE_IMMUTABLE_LEVELS parameter.

[Ian Romanick]

On 08/01/2013 03:49 PM, Matt Turner wrote:
> ---
>   tests/spec/gles-3.0/CMakeLists.gles3.txt       |   1 +
>   tests/spec/gles-3.0/texture-immutable-levels.c | 106 +++++++++++++++++++++++++
>   2 files changed, 107 insertions(+)
>   create mode 100644 tests/spec/gles-3.0/texture-immutable-levels.c
>
> diff --git a/tests/spec/gles-3.0/CMakeLists.gles3.txt b/tests/spec/gles-3.0/CMakeLists.gles3.txt
> index 13cef0c..38efbed 100644
> --- a/tests/spec/gles-3.0/CMakeLists.gles3.txt
> +++ b/tests/spec/gles-3.0/CMakeLists.gles3.txt
> @@ -4,5 +4,6 @@ link_libraries(
>
>   piglit_add_executable(minmax_${piglit_target_api} minmax.c)
>   piglit_add_executable(oes_compressed_etc2_texture-miptree_gles3 oes_compressed_etc2_texture-miptree.c)
> +piglit_add_executable(texture-immutable-levels_gles3 texture-immutable-levels.c)
>
>   # vim: ft=cmake:
> diff --git a/tests/spec/gles-3.0/texture-immutable-levels.c b/tests/spec/gles-3.0/texture-immutable-levels.c
> new file mode 100644
> index 0000000..ac86c1f
> --- /dev/null
> +++ b/tests/spec/gles-3.0/texture-immutable-levels.c
> @@ -0,0 +1,106 @@
> +/* Copyright © 2013 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * on the rights to use, copy, modify, merge, publish, distribute, sub
> + * license, and/or sell copies of the Software, and to permit persons to whom
> + * the Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NON-INFRINGEMENT.  IN NO EVENT SHALL VMWARE AND/OR THEIR SUPPLIERS
> + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> + * SOFTWARE.
> + */
> +
> +/**
> + * Tests the TEXTURE_IMMUTABLE_LEVELS parameter.
> + *
> + * The GL ES 3.0 spec says:
> + *
> + *     "If the command is successful, TEXTURE_IMMUTABLE_FORMAT becomes
> + *      TRUE and TEXTURE_IMMUTABLE_LEVELS becomes levels."
> + *
> + * where <command> is either glTexStorage2D or glTexStorage3D.
> + *
> + * Test by calling glTexStorage*D with <levels> = 3, <width>, <height>, and
> + * <depth> = 32; and then confirming that TEXTURE_IMMUTABLE_LEVELS was
> + * correctly set to <levels>.
> + */
> +
> +#include "piglit-util-gl-common.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +	config.supports_gl_es_version = 30;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +	static const GLfloat data[32][32];
> +	GLuint tex[3];
> +	GLint level;
> +
> +	/* The GL ES 3.0 spec says:
> +	 *
> +	 *     "The [initial] value of TEXTURE_IMMUTABLE_LEVELS is 0."
> +	 */
> +	glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_IMMUTABLE_LEVELS, &level);
> +	if (!piglit_check_gl_error(GL_NO_ERROR)) {
> +		piglit_report_result(PIGLIT_FAIL);
> +	}
> +	if (level != 0) {
> +		printf("Expected 0 levels initially, but glGetTexParameteriv "
> +		       "returned %d for GL_TEXTURE_1D.\n", level);
> +		piglit_report_result(PIGLIT_FAIL);
> +	}
> +
> +	glGenTextures(3, tex);
> +
> +	glBindTexture(GL_TEXTURE_2D, tex[0]);
> +	glTexStorage2D(GL_TEXTURE_2D, 3, GL_RGBA8, 32, 32);
> +	glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_IMMUTABLE_LEVELS, &level);
> +	if (level != 3) {
> +		printf("Expected 3 levels, but glGetTexParameteriv returned "
> +		       "%d for GL_TEXTURE_2D.\n", level);
> +		piglit_report_result(PIGLIT_FAIL);
> +	}
> +
> +	glBindTexture(GL_TEXTURE_3D, tex[1]);
> +	glTexStorage3D(GL_TEXTURE_3D, 3, GL_RGBA8, 32, 32, 32);
> +	glGetTexParameteriv(GL_TEXTURE_3D, GL_TEXTURE_IMMUTABLE_LEVELS, &level);
> +	if (level != 3) {
> +		printf("Expected 3 levels, but glGetTexParameterfv returned "
> +		       "%d for GL_TEXTURE_3D.\n", level);
> +		piglit_report_result(PIGLIT_FAIL);
> +	}
> +
> +	glBindTexture(GL_TEXTURE_2D, tex[2]);
> +	glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 32, 32, 0, GL_RGBA, GL_FLOAT, (const GLvoid *) data);

Why not pass NULL for pixels?

> +	glGetTexParameteriv(GL_TEXTURE_2D, GL_TEXTURE_IMMUTABLE_LEVELS, &level);
> +	if (level != 0) {
> +		printf("Expected 0 levels, but glGetTexParameteriv returned "
> +		       "%d for GL_TEXTURE_2D.\n", level);
> +		piglit_report_result(PIGLIT_FAIL);
> +	}

Do this check for glTexture3D too.

I'm waffling about whether it's worth the effort to do these checks for 
GL_TEXTURE_CUBE_MAP and GL_TEXTURE_2D_ARRAY as well...

> +
> +	glDeleteTextures(3, tex);
> +
> +	piglit_report_result(PIGLIT_PASS);
> +	return 0;
> +}
> +
> +void
> +piglit_init(int argc, char *argv[])
> +{
> +}
>