[Piglit] [PATCH 1/4] GLSL 1.50: Test that layout qualifier ids can be listed in any order

[Paul Berry]

On 6 August 2013 10:01, Nicholas Mack <nichmack at gmail.com> wrote:

> ---
>  .../spec/glsl-1.50/compiler/layout-any-order-ids.frag | 19
> +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 tests/spec/glsl-1.50/compiler/layout-any-order-ids.frag
>
> diff --git a/tests/spec/glsl-1.50/compiler/layout-any-order-ids.frag
> b/tests/spec/glsl-1.50/compiler/layout-any-order-ids.frag
> new file mode 100644
> index 0000000..4e42b0d
> --- /dev/null
> +++ b/tests/spec/glsl-1.50/compiler/layout-any-order-ids.frag
> @@ -0,0 +1,19 @@
> +// [config]
> +// expect_result: pass
> +// glsl_version: 1.50
> +// check_link: true
> +// [end config]
> +//
> +// Section 4.3.8(Layout Qualifiers) of the GLSL 1.50 spec says:
> +// "Generally, (layout-qualifiers) can be listed in any order.
> Order-dependent
> +//  meanings exist only if explicitly (said otherwise)"
>

The fact that you've paraphrased the spec text made it difficult to find.
I would recommend just quoting the full paragraph:

// The tokens in any layout-qualifier-id-list are identifiers,
// not keywords. Generally, they can be listed in any
// order. Order-dependent meanings exist only if explicitly
// called out below. Similarly, these identifiers are not case
// sensitive, unless explicitly noted otherwise.

so that the context is clear.

But I'm nit-picking.  Either way, the patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


> +
> +#version 150
> +
> +layout(pixel_center_integer, origin_upper_left) in vec4 gl_FragCoord;
> +layout(origin_upper_left, pixel_center_integer) in vec4 gl_FragCoord;
> +
> +void main()
> +{
> +       gl_FragColor = vec4(0., 1., 0., 1.);
> +}
> --
> 1.8.3.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130808/706b6e88/attachment.html>