[Piglit] [PATCH] glsl-1.20: Fix the spec quotation

Anuj Phogat anuj.phogat at gmail.com
Tue Aug 13 17:10:13 PDT 2013


On Thu, Aug 8, 2013 at 5:36 PM, Ian Romanick <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The bit of spec text quoted in the test had nothing to do with what
> was being tested.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  .../array-function-return-unsized.vert                   | 16 +++-------------
>  1 file changed, 3 insertions(+), 13 deletions(-)
>
> diff --git a/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-function-return-unsized.vert b/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-function-return-unsized.vert
> index ba4ff33..9e0b3d0 100644
> --- a/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-function-return-unsized.vert
> +++ b/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-function-return-unsized.vert
> @@ -3,20 +3,10 @@
>   * glsl_version: 1.20
>   * [end config]
>   *
> - * From page 19 (page 25 of the PDF) of the GLSL 1.20 spec:
> + * Section 6.1 (Function Definitions) of the GLSL 1.20 spec says:
>   *
> - *     "This type can be used anywhere any other type can be used, including
> - *     as the return value from a function
> - *
> - *         float[5] foo() { }
> - *
> - *     as a constructor of an array
> - *
> - *         float[5](3.4, 4.2, 5.0, 5.2, 1.1)
> - *
> - *     as an unnamed parameter
> - *
> - *         void foo(float[5])"
> + *     "Arrays are allowed as arguments and as the return type. In
> + *     both cases, the array must be explicitly sized."
>   */
>  #version 120
>
> --
> 1.8.1.4
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the Piglit mailing list