[Piglit] [PATCH] glsl-1.30: Allow empty declarations with precision qualifier

[Ian Romanick]

On 08/13/2013 04:25 PM, Anuj Phogat wrote:
> On Tue, Aug 13, 2013 at 1:17 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> This compiles on both NVIDIA (304.64 on GTX 260) and AMD (Catalyst
>> 12.06 on Radeon HD 3650).  It also compiles on all versions of Mesa
>> that support GLSL 1.30.
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> Cc: Kenneth Graunke <kenneth at whitecape.org>
>> ---
>>   tests/glslparsertest/glsl2/precision-05.vert | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/tests/glslparsertest/glsl2/precision-05.vert b/tests/glslparsertest/glsl2/precision-05.vert
>> index a7fd4d9..413d231 100644
>> --- a/tests/glslparsertest/glsl2/precision-05.vert
>> +++ b/tests/glslparsertest/glsl2/precision-05.vert
>> @@ -1,13 +1,14 @@
>>   // [config]
>> -// expect_result: fail
>> +// expect_result: pass
>>   // glsl_version: 1.30
>> -//
>> -// # NOTE: Config section was auto-generated from file
>> -// # NOTE: 'glslparser.tests' at git revision
>> -// # NOTE: 6cc17ae70b70d150aa1751f8e28db7b2a9bd50f0
>>   // [end config]
>>
>>   #version 130
>> -/* FAIL - keyword 'precision' required. */
>> +
>> +/* Keyword 'precision' is required required for this to set the default
> 'required' is repeated.

It sure is.  I'll fix that.

>> + * precision.  However, the language allows empty declarations with or without
>> + * a precision qualifier.  Other shipping implementations allow this syntax,
>> + * and there is nothing in the spec that forbids it.
>> + */
>>   lowp float;
>>   mediump int;
>> --
>> 1.8.1.4
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit
>
> Other than above typo this patch is:
> Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
>