[Piglit] [PATCH 8/9] GL3.2 GL_ARB_sync: Test that a sync object is initialized with the correct properties

[Kenneth Graunke]

On 07/25/2013 03:43 PM, Nicholas Mack wrote:
> ---
>   tests/spec/arb_sync/CMakeLists.gl.txt |   2 +-
>   tests/spec/arb_sync/sync-initialize.c | 104 ++++++++++++++++++++++++++++++++++
>   2 files changed, 105 insertions(+), 1 deletion(-)
>   create mode 100644 tests/spec/arb_sync/sync-initialize.c
>
> diff --git a/tests/spec/arb_sync/CMakeLists.gl.txt b/tests/spec/arb_sync/CMakeLists.gl.txt
> index 1c5490a..632e3ad 100644
> --- a/tests/spec/arb_sync/CMakeLists.gl.txt
> +++ b/tests/spec/arb_sync/CMakeLists.gl.txt
> @@ -10,6 +10,6 @@ link_libraries (
>   	${OPENGL_glu_LIBRARY}
>   )
>
> -piglit_add_executable (arb_sync-is-sync IsSync.c)
> +piglit_add_executable (arb_sync-sync-initialize sync-initialize.c)
>   piglit_add_executable (arb_sync-repeat-wait repeat-wait.c)
>   piglit_add_executable (arb_sync-timeout-zero timeout-zero.c)
> diff --git a/tests/spec/arb_sync/sync-initialize.c b/tests/spec/arb_sync/sync-initialize.c
> new file mode 100644
> index 0000000..1e74244
> --- /dev/null
> +++ b/tests/spec/arb_sync/sync-initialize.c
> @@ -0,0 +1,104 @@
> +/* Copyright © 2013 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/*
> + *Test that a sync is initialized correctly with FenceSync
> + *
> + *
> + *Section 5.2(Sync Objects and Fences) of OpenGL 3.2 Core says:
> + * "Table 5.1: Initial properties of a sync object created with FenceSync."
> + *
> + * Property Name 	Property Value
> + *--------------------------------------
> + * OBJECT_TYPE		SYNC_FENCE
> + * SYNC_CONDITION	<condition>
> + * SYNC_STATUS 		UNSIGNALED
> + * SYNC_FLAGS 		<flags>
> + */
> +
> +#include "piglit-util-gl-common.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +config.supports_gl_compat_version = 10;
> +config.supports_gl_core_version = 31;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +	/* UNREACHED */
> +	return PIGLIT_FAIL;
> +}
> +
> +static GLsync test;
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +	bool pass = true;
> +	GLsizei length;
> +	GLint value;
> +
> +	if (piglit_get_gl_version() < 32) {
> +		piglit_require_extension("GL_ARB_sync");
> +	}
> +
> +	test = glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0);
> +
> +	//Test initialed to unsignaled
> +	glGetSynciv(test, GL_SYNC_STATUS, 1, &length, &value);
> +	if(value != GL_UNSIGNALED) {
> +		printf("Expected GL_UNSIGNALED but returned: %s\n",
> +			piglit_get_gl_enum_name(value));
> +		pass = false;
> +	}
> +
> +	//Test initialized to given condition
> +	glGetSynciv(test, GL_SYNC_CONDITION, 1, &length, &value);
> +	if(value != GL_SYNC_GPU_COMMANDS_COMPLETE) {
> +		printf("Expected GL_SYNC_GPU_COMMANDS_COMPLETE but returned: %s\n",
> +			piglit_get_gl_enum_name(value));
> +		pass = false;
> +	}
> +
> +	//Test initialized with given flag
> +	glGetSynciv(test, GL_SYNC_FLAGS, 1, &length, &value);
> +	if(value != 0) {
> +		printf("Expected 0 but returned: %d\n",

Perhaps "Expected GL_SYNC_FLAGS == 0, but was %d\n"?

That way, the error message lets you know right away that GL_SYNC_FLAGS 
is wrong..."Expected 0" is kind of generic.  Not a big deal though.

> +			value);
> +		pass = false;
> +	}
> +
> +	//Test initialized as fence type
> +	glGetSynciv(test, GL_OBJECT_TYPE, 1, &length, &value);
> +	if(value != GL_SYNC_FENCE) {
> +		printf("Expected GL_SYNC_FENCE but returned: %s\n",
> +			piglit_get_gl_enum_name(value));
> +		pass = false;
> +	}

You should also check that length gets updated with the correct value. 
It's good practice to initialize it with a known value beforehand, i.e.

length = 0xcccccccc;
glGetSynciv(test, GL_OBJECT_TYPE, 1, &length, &value);

that way you know if it actually changed.

> +	glDeleteSync(test);
> +
> +	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}
>