[Piglit] [v9 13/13] tests/spec: EXT_image_dma_buf_import intel img-ext with dma-buf only
chad.versace at linux.intel.com
Mon Aug 19 11:38:41 PDT 2013
On 08/09/2013 03:43 AM, Topi Pohjolainen wrote:
> v2 (Chad): add dependency to 'EGL_KHR_image_base'
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> tests/all.tests | 1 +
> .../ext_image_dma_buf_import/CMakeLists.gles2.txt | 1 +
> .../intel_external_sampler_with_dma_only.c | 103 +++++++++++++++++++++
> 3 files changed, 105 insertions(+)
> create mode 100644 tests/spec/ext_image_dma_buf_import/intel_external_sampler_with_dma_only.c
> + * @file intel_external_sampler_with_dma_only.c
> + *
> + * Intel driver allows image external sampler to be used only with imported
> + * dma buffers. This test creates an egl image based on a 2D-texture and tries
> + * to further use the image as target for an external texture.
> + */
I found the above comment confusing. After reading it, I was still unsure exactly
what behavior this test was trying verify. I believe I was able to correctly determine
the test's intent only due to the face-to-face conversations we had.
Please fixup the last sentence to this, and I think the test's intent becomes clear:
"This test creates an egl image based on a 2D-texture, attempts to use the image as
target for an external texture, and expects the attempt to fail with GL_INVALID_OPERATION".
With that clarification,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
More information about the Piglit