[Piglit] [PATCH 06/11] arb_texture_buffer_object: Verify some behavior when the extenion isn't supported

Ian Romanick idr at freedesktop.org
Wed Aug 21 09:07:58 PDT 2013


From: Ian Romanick <ian.d.romanick at intel.com>

If the extension is not supported, applications should not be able to
bind to the texture target or the buffer object target.

v2: Add to all.tests.  Require GL version < 3.1 because the extension
became part of the core spec then.  Comments by Eric Anholt.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
 tests/all.tests                                    |  1 +
 .../arb_texture_buffer_object/CMakeLists.gl.txt    |  1 +
 .../negative-unsupported.c                         | 67 ++++++++++++++++++++++
 3 files changed, 69 insertions(+)
 create mode 100644 tests/spec/arb_texture_buffer_object/negative-unsupported.c

diff --git a/tests/all.tests b/tests/all.tests
index a0d3b5c..ab75f99 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1298,6 +1298,7 @@ arb_texture_buffer_object['minmax'] = concurrent_test('arb_texture_buffer_object
 arb_texture_buffer_object['negative-bad-bo'] = concurrent_test('arb_texture_buffer_object-negative-bad-bo')
 arb_texture_buffer_object['negative-bad-format'] = concurrent_test('arb_texture_buffer_object-negative-bad-format')
 arb_texture_buffer_object['negative-bad-target'] = concurrent_test('arb_texture_buffer_object-negative-bad-target')
+arb_texture_buffer_object['negative-unsupported'] = concurrent_test('arb_texture_buffer_object-negative-unsupported')
 arb_texture_buffer_object['unused-name'] = concurrent_test('arb_texture_buffer_object-unused-name')
 
 arb_texture_buffer_range = Group()
diff --git a/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt b/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt
index 83d953e..e1f3a2e 100644
--- a/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt
+++ b/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt
@@ -17,6 +17,7 @@ piglit_add_executable (arb_texture_buffer_object-minmax minmax.c)
 piglit_add_executable (arb_texture_buffer_object-negative-bad-bo negative-bad-bo.c)
 piglit_add_executable (arb_texture_buffer_object-negative-bad-format negative-bad-format.c)
 piglit_add_executable (arb_texture_buffer_object-negative-bad-target negative-bad-target.c)
+piglit_add_executable (arb_texture_buffer_object-negative-unsupported negative-unsupported.c)
 piglit_add_executable (arb_texture_buffer_object-render-no-bo render-no-bo.c)
 piglit_add_executable (arb_texture_buffer_object-unused-name unused-name.c)
 piglit_add_executable (arb_texture_buffer_object-fetch-outside-bounds fetch-outside-bounds.c)
diff --git a/tests/spec/arb_texture_buffer_object/negative-unsupported.c b/tests/spec/arb_texture_buffer_object/negative-unsupported.c
new file mode 100644
index 0000000..d465c97
--- /dev/null
+++ b/tests/spec/arb_texture_buffer_object/negative-unsupported.c
@@ -0,0 +1,67 @@
+/* Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/** @file negative-unsupported.c
+ * Verify that the GL_TEXTURE_BUFFER target cannot be used when the
+ * extension is not supported.
+ */
+
+#include "piglit-util-gl-common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_compat_version = 10;
+
+	config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL; /* UNREACHED */
+}
+
+
+void
+piglit_init(int argc, char **argv)
+{
+	GLuint tex;
+	GLuint bo;
+	bool pass = true;
+
+	piglit_require_not_extension("GL_ARB_texture_buffer_object");
+	if (piglit_get_gl_version() >= 31)
+		piglit_report_result(PIGLIT_SKIP);
+
+	glGenTextures(1, &tex);
+	glBindTexture(GL_TEXTURE_BUFFER, tex);
+	pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;
+
+	glGenBuffers(1, &bo);
+	glBindBuffer(GL_TEXTURE_BUFFER, bo);
+	pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;
+
+	glDeleteBuffers(1, &bo);
+	glDeleteTextures(1, &tex);
+	piglit_report_result(PIGLIT_PASS);
+}
-- 
1.8.1.4



More information about the Piglit mailing list