[Piglit] [PATCH 2/5] GL 3.2: Test that the initial value of provoking vertex mode is LAST_VERTEX_CONVENTION

Paul Berry stereotype441 at gmail.com
Thu Aug 22 14:38:22 PDT 2013


On 20 August 2013 10:56, Nicholas Mack <nichmack at gmail.com> wrote:

> ---
>  tests/spec/arb_provoking_vertex/CMakeLists.gl.txt  |  1 +
>  .../provoking-vertex-initial.c                     | 64
> ++++++++++++++++++++++
>  2 files changed, 65 insertions(+)
>  create mode 100644
> tests/spec/arb_provoking_vertex/provoking-vertex-initial.c
>

As with patch 1, this test should be added to all.tests during this patch,
rather than waiting until patch 5.

With that fixed, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


>
> diff --git a/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt
> b/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt
> index e952392..cdcd99f 100644
> --- a/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt
> +++ b/tests/spec/arb_provoking_vertex/CMakeLists.gl.txt
> @@ -10,5 +10,6 @@ link_libraries (
>  )
>
>  piglit_add_executable (arb-provoking-vertex-control
> provoking-vertex-control.c)
> +piglit_add_executable (arb-provoking-vertex-initial
> provoking-vertex-initial.c)
>
>  # vim: ft=cmake:
> diff --git a/tests/spec/arb_provoking_vertex/provoking-vertex-initial.c
> b/tests/spec/arb_provoking_vertex/provoking-vertex-initial.c
> new file mode 100644
> index 0000000..1bd30aa
> --- /dev/null
> +++ b/tests/spec/arb_provoking_vertex/provoking-vertex-initial.c
> @@ -0,0 +1,64 @@
> +/**
> + * Copyright © 2013 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the
> "Software"),
> + * to deal in the Software without restriction, including without
> limitation
> + * the rights to use, copy, modify, merge, publish, distribute,
> sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the
> next
> + * paragraph) shall be included in all copies or substantial portions of
> the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT
> SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/**
> + * Test that the intitial value of PROVOKING_VERTEX is
> LAST_VERTEX_CONVENTION
> + *
> + * Section 2.18(Flatshading) of OpenGL 3.2 Core says:
> + * "The initial value of the provoking vertex mode is
> LAST_VERTEX_CONVENTION."
> + *
> + */
> +
> +#include "piglit-util-gl-common.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +
> +       config.supports_gl_compat_version = 32;
> +        config.supports_gl_core_version = 32;
> +
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +       bool pass = true;
> +       int ret = 0;
> +
> +       glGetIntegerv(GL_PROVOKING_VERTEX, &ret);
> +       if(ret != GL_LAST_VERTEX_CONVENTION) {
> +               printf("GL_PROVOKING_VERTEX was expected to be
> GL_LAST_VERTEX"
> +                       "_CONVENTION, but %s was returned.\n",
> +                        piglit_get_gl_enum_name(ret));
> +               pass = false;
> +       }
> +
> +       pass = piglit_check_gl_error(GL_NO_ERROR) && pass;
> +
> +       piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +}
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +       return PIGLIT_FAIL;
> +}
> --
> 1.8.3.1
>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130822/bc00ac94/attachment.html>


More information about the Piglit mailing list