[Piglit] [PATCH 5/8] arb_gpu_shader5: Add ldexp constant eval execution test.

Matt Turner mattst88 at gmail.com
Fri Aug 23 10:11:37 PDT 2013


On Fri, Aug 23, 2013 at 7:24 AM, Paul Berry <stereotype441 at gmail.com> wrote:
> On 22 August 2013 16:07, Matt Turner <mattst88 at gmail.com> wrote:
>>
>> ---
>>  .../built-in-functions/const-ldexp.shader-test     | 62
>> ++++++++++++++++++++++
>>  1 file changed, 62 insertions(+)
>>  create mode 100644
>> tests/spec/arb_gpu_shader5/execution/built-in-functions/const-ldexp.shader-test
>>
>> diff --git
>> a/tests/spec/arb_gpu_shader5/execution/built-in-functions/const-ldexp.shader-test
>> b/tests/spec/arb_gpu_shader5/execution/built-in-functions/const-ldexp.shader-test
>> new file mode 100644
>> index 0000000..5a6752c
>> --- /dev/null
>> +++
>> b/tests/spec/arb_gpu_shader5/execution/built-in-functions/const-ldexp.shader-test
>> @@ -0,0 +1,62 @@
>> +[require]
>> +GLSL >= 1.50
>> +GL_ARB_gpu_shader5
>> +
>> +[vertex shader]
>> +in vec4 vertex;
>> +
>> +void main() {
>> +       gl_Position = vertex;
>> +}
>> +
>> +[fragment shader]
>> +#extension GL_ARB_gpu_shader5 : enable
>> +
>> +void bad_constant_folding();
>
>
> Ah, I see what you did there.  By not declaring this function you ensure
> that there will be a link error if constants are folded incorrectly.
> Clever.

I can't claim credit. It's what we do in
tests/shaders/glsl-const-folding-01.shader_test which made me believe
it an okay approach.


More information about the Piglit mailing list