[Piglit] [PATCH 8/8] arb_gpu_shader5: Add fma constant eval execution test.

Matt Turner mattst88 at gmail.com
Fri Aug 23 16:38:14 PDT 2013

On Fri, Aug 23, 2013 at 7:29 AM, Paul Berry <stereotype441 at gmail.com> wrote:
> This test doesn't verify that fma() is constant-folded.  I'd recommend doing
> the array size trick (see my comments on patch 5/8) here as well.
> With that changed, the patch is:
> Reviewed-by: Paul Berry <stereotype441 at gmail.com>
> Patches 1-4 and 6-7 are also:
> Reviewed-by: Paul Berry <stereotype441 at gmail.com>

I've fixed both patches 5 and 8 in the same way as I've done for the
preexisting const gpu shader5 tests (see "[PATCH] arb_gpu_shader5: Use
array sizing to catch bad constant folding.").

Thanks for the reviews and suggestions!

More information about the Piglit mailing list