[Piglit] [PATCH 10/13] glsl: Allow limit checking on negative constants

Ian Romanick idr at freedesktop.org
Mon Aug 26 16:44:51 PDT 2013


On 08/26/2013 02:49 PM, Eric Anholt wrote:
> Ian Romanick <idr at freedesktop.org> writes:
>
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> GLSL ES 3.00 adds gl_MinProgramTexelOffset with a negative value.
>> This constant must be -8 or less.  For now, assume that all negative
>> constants want a <= comparison.  The alternative is to compare the
>> name for 'gl_Min' instead of 'gl_Max'.
>
> I'd be more comfortable with the string_match() for gl_Min, and it looks
> like it would be trivial.

Yeah, I figured someone was going to say that. :)  I got the idea while 
I was writing the commit message, and I just felt lazy.  I can change it.



More information about the Piglit mailing list