[Piglit] [PATCH 02/13 v2] glsl: Add program to test all shader built-in constants
Ian Romanick
idr at freedesktop.org
Mon Aug 26 19:13:19 PDT 2013
From: Ian Romanick <ian.d.romanick at intel.com>
Using a simple text file, all shader built-in constants can be tested.
This has several advantages over the previous methodology.
1. All of the built-in constants and their expected values are kept in
one place per GLSL version.
2. The tests use the array-size idiom of many piglit tests which
guarantees that the values being tested are actually contants.
3. Since the tests are not execution tests, they run much faster. The
single top-level test can also run concurrently with other tests. The
speed difference is trivial most of the time, but in simlation
environments, each pixel drawn takes a very long time. You're welcome,
Chad.
v2: Use required_gl_version_from_glsl_version, use string_match for
"gl_Max" comparison, and fix some whitespace issues (all suggested by
Eric). Also use strcpy_to_space to simplify a bit of error handling
code.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
---
tests/shaders/CMakeLists.gl.txt | 1 +
tests/shaders/CMakeLists.gles2.txt | 1 +
tests/shaders/CMakeLists.gles3.txt | 1 +
tests/shaders/built-in-constants.c | 348 +++++++++++++++++++++++++++++++++++++
4 files changed, 351 insertions(+)
create mode 100644 tests/shaders/built-in-constants.c
diff --git a/tests/shaders/CMakeLists.gl.txt b/tests/shaders/CMakeLists.gl.txt
index f71d683..03f4ebb 100644
--- a/tests/shaders/CMakeLists.gl.txt
+++ b/tests/shaders/CMakeLists.gl.txt
@@ -16,6 +16,7 @@ piglit_add_executable (activeprogram-bad-program activeprogram-bad-program.c)
piglit_add_executable (activeprogram-get activeprogram-get.c)
piglit_add_executable (ati-fs-bad-delete ati-fs-bad-delete.c)
piglit_add_executable (attribute0 attribute0.c)
+piglit_add_executable (built-in-constants built-in-constants.c parser_utils.c)
piglit_add_executable (createshaderprogram-bad-type createshaderprogram-bad-type.c)
piglit_add_executable (createshaderprogram-attached-shaders createshaderprogram-attached-shaders.c)
piglit_add_executable (trinity-fp1 trinity-fp1.c)
diff --git a/tests/shaders/CMakeLists.gles2.txt b/tests/shaders/CMakeLists.gles2.txt
index efb8373..bdec363 100644
--- a/tests/shaders/CMakeLists.gles2.txt
+++ b/tests/shaders/CMakeLists.gles2.txt
@@ -2,6 +2,7 @@ link_libraries(
piglitutil_${piglit_target_api}
)
+piglit_add_executable (built-in-constants_${piglit_target_api} built-in-constants.c parser_utils.c)
piglit_add_executable(shader_runner_gles2 shader_runner.c parser_utils.c)
# vim: ft=cmake:
diff --git a/tests/shaders/CMakeLists.gles3.txt b/tests/shaders/CMakeLists.gles3.txt
index 4e143ae..18b8c35 100644
--- a/tests/shaders/CMakeLists.gles3.txt
+++ b/tests/shaders/CMakeLists.gles3.txt
@@ -2,6 +2,7 @@ link_libraries(
piglitutil_${piglit_target_api}
)
+piglit_add_executable (built-in-constants_${piglit_target_api} built-in-constants.c parser_utils.c)
piglit_add_executable(shader_runner_${piglit_target_api} shader_runner.c parser_utils.c)
# vim: ft=cmake:
diff --git a/tests/shaders/built-in-constants.c b/tests/shaders/built-in-constants.c
new file mode 100644
index 0000000..8a534f7
--- /dev/null
+++ b/tests/shaders/built-in-constants.c
@@ -0,0 +1,348 @@
+/*
+ * Copyright © 2013 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+#include <stdbool.h>
+#include <string.h>
+
+#include "piglit-util-gl-common.h"
+#include "parser_utils.h"
+
+static void parse_file(const char *filename);
+
+struct test_vector {
+ const char *name;
+ int minimum;
+};
+
+struct test_vector tests[500];
+unsigned num_tests = 0;
+
+int required_glsl_version = 0;
+char *required_glsl_version_string = NULL;
+
+
+static const char *const uniform_template =
+ "uniform float f[%s >= %d ? 1 : -1];\n"
+ ;
+
+static const char *const vertex_shader_body =
+ "void main() { gl_Position = vec4(f[0]); }\n"
+ ;
+
+static const char *const geometry_shader_body =
+ "layout(points) in;\n"
+ "layout(points, max_vertices = 1) out;\n"
+ "void main() { gl_Position = vec4(f[0]); EmitVertex(); }\n"
+ ;
+
+/* The __VERSION__ stuff is to work-around gl_FragColor not existing in GLSL
+ * ES 3.00.
+ */
+static const char *const fragment_shader_body =
+ "#if __VERSION__ >= 300\n"
+ "out vec4 color;\n"
+ "#define gl_FragColor color\n"
+ "#endif\n"
+ "void main() { gl_FragColor = vec4(f[0]); }\n"
+ ;
+
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+ parse_file(argv[1]);
+
+ switch (required_glsl_version) {
+ case 100:
+ config.supports_gl_compat_version = 10;
+ config.supports_gl_es_version = 20;
+ break;
+ case 300:
+ config.supports_gl_compat_version = 10;
+ config.supports_gl_es_version = 30;
+ break;
+ default: {
+ const unsigned int gl_version
+ = required_gl_version_from_glsl_version(required_glsl_version);
+ config.supports_gl_compat_version = gl_version;
+ if (gl_version < 31)
+ config.supports_gl_core_version = 0;
+ else
+ config.supports_gl_core_version = gl_version;
+ break;
+ }
+ }
+
+ config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+enum piglit_result
+piglit_display(void)
+{
+ /* UNREACHED */
+ return PIGLIT_FAIL;
+}
+
+
+/**
+ * Comparison function for qsort of test_vector list
+ */
+static int
+compar(const void *_a, const void *_b)
+{
+ const struct test_vector *a = (const struct test_vector *) _a;
+ const struct test_vector *b = (const struct test_vector *) _b;
+
+ return strcmp(a->name, b->name);
+}
+
+/**
+ * Parse the file of values to test, fill in test vector list.
+ */
+void
+parse_file(const char *filename)
+{
+ unsigned text_size;
+ char *text = piglit_load_text_file(filename, &text_size);
+ char *line = text;
+ int count;
+ int major;
+ int minor;
+
+ /* The format of the test file is:
+ *
+ * major.minor
+ * gl_MaxFoo 8
+ * gl_MaxBar 16
+ */
+
+ /* Process the version requirement.
+ */
+ count = sscanf(line, "%d.%d", &major, &minor);
+ if (count != 2) {
+ fprintf(stderr, "Parse error in version line.\n");
+ piglit_report_result(PIGLIT_FAIL);
+ }
+
+ required_glsl_version = major * 100 + minor;
+
+ /* Skip to the next line.
+ */
+ line = strchrnul(line, '\n');
+ if (line[0] != '\0')
+ line++;
+
+ while (line[0] != '\0') {
+ char *endptr;
+
+ line = (char *) eat_whitespace(line);
+
+ if (string_match("gl_Max", line) != 0) {
+ char bad_name[80];
+
+ strcpy_to_space(bad_name, line);
+ fprintf(stderr,
+ "Invalid built-in constant name \"%s\".\n",
+ bad_name);
+ piglit_report_result(PIGLIT_FAIL);
+ }
+
+ tests[num_tests].name = line;
+
+ line = (char *) eat_text(line);
+ line[0] = '\0';
+ line++;
+
+ line = (char *) eat_whitespace(line);
+
+ tests[num_tests].minimum = strtol(line, &endptr, 0);
+ if (endptr == line) {
+ char bad_number[80];
+
+ strcpy_to_space(bad_number, line);
+
+ fprintf(stderr,
+ "Invalid built-in constant value \"%s\".\n",
+ bad_number);
+ piglit_report_result(PIGLIT_FAIL);
+ }
+ line = endptr;
+
+ num_tests++;
+
+ /* Skip to the next line.
+ */
+ line = strchrnul(line, '\n');
+ if (line[0] != '\0')
+ line++;
+ }
+
+ /* After parsing the full list of values to test, sort the list by
+ * variable name. This ensures that the piglit results will be
+ * generated in a consistent order... no matter what happens in the
+ * control file.
+ */
+ qsort(tests, num_tests, sizeof(tests[0]), compar);
+}
+
+static bool
+check_compile_status(const char *name, GLuint sh)
+{
+ GLint ok;
+
+ glGetShaderiv(sh, GL_COMPILE_STATUS, &ok);
+ if (!ok) {
+ GLchar *info;
+ GLint size;
+
+ glGetShaderiv(sh, GL_INFO_LOG_LENGTH, &size);
+ info = malloc(size);
+ glGetShaderInfoLog(sh, size, NULL, info);
+
+ fprintf(stderr,
+ "Failed to compile shader %s: %s\n",
+ name, info);
+
+ free(info);
+ }
+
+ return !!ok;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+ bool pass = true;
+ char uniform[80];
+ char *version_string = NULL;
+ unsigned i;
+
+ const char *shader_source[3];
+
+ GLuint test_vs;
+ GLuint test_gs = 0;
+ GLuint test_fs;
+
+ bool is_es;
+ int major;
+ int minor;
+ int glsl_version;
+
+ piglit_get_glsl_version(&is_es, &major, &minor);
+ glsl_version = major * 100 + minor;
+ if (glsl_version < required_glsl_version)
+ piglit_report_result(PIGLIT_SKIP);
+
+ /* Generate the version declaration that will be used by all of the
+ * shaders in the test run.
+ */
+ asprintf(&version_string,
+ "#version %d %s\n"
+ "#ifdef GL_ES\n"
+ "precision mediump float;\n"
+ "#endif\n",
+ required_glsl_version,
+ required_glsl_version == 300 ? "es" : "");
+
+ /* Create the shaders that will be used for the real part of the test.
+ */
+ test_vs = glCreateShader(GL_VERTEX_SHADER);
+ test_fs = glCreateShader(GL_FRAGMENT_SHADER);
+
+ if (glsl_version >= 150)
+ test_gs = glCreateShader(GL_GEOMETRY_SHADER);
+
+ for (i = 0; i < num_tests; i++) {
+ bool subtest_pass = true;
+
+ /* Generate the uniform declaration for the test. This will
+ * be shared by all shader stages.
+ */
+ snprintf(uniform, sizeof(uniform),
+ uniform_template,
+ tests[i].name, tests[i].minimum);
+
+ /* Try to compile the vertex shader.
+ */
+ shader_source[0] = version_string;
+ shader_source[1] = uniform;
+ shader_source[2] = vertex_shader_body;
+
+ glShaderSource(test_vs, 3, shader_source, NULL);
+ glCompileShader(test_vs);
+
+ subtest_pass = check_compile_status(tests[i].name, test_vs)
+ && subtest_pass;
+
+ /* Try to compile the geometry shader.
+ */
+ if (test_gs != 0) {
+ shader_source[0] = version_string;
+ shader_source[1] = uniform;
+ shader_source[2] = geometry_shader_body;
+
+ glShaderSource(test_gs, 3, shader_source, NULL);
+ glCompileShader(test_gs);
+
+ subtest_pass = check_compile_status(tests[i].name, test_gs)
+ && subtest_pass;
+ }
+
+ /* Try to compile the fragment shader.
+ */
+ shader_source[0] = version_string;
+ shader_source[1] = uniform;
+ shader_source[2] = fragment_shader_body;
+
+ glShaderSource(test_fs, 3, shader_source, NULL);
+ glCompileShader(test_fs);
+
+ subtest_pass = check_compile_status(tests[i].name, test_fs)
+ && subtest_pass;
+
+ /* If both compilation phases passed, try to link the shaders
+ * together.
+ */
+ if (subtest_pass) {
+ GLuint prog = glCreateProgram();
+
+ glAttachShader(prog, test_vs);
+ glAttachShader(prog, test_fs);
+
+ if (test_gs != 0)
+ glAttachShader(prog, test_gs);
+
+ glLinkProgram(prog);
+ subtest_pass = !!piglit_link_check_status(prog);
+
+ glDeleteProgram(prog);
+ }
+
+ piglit_report_subtest_result(subtest_pass ? PIGLIT_PASS : PIGLIT_FAIL,
+ "%s", tests[i].name);
+
+ pass = subtest_pass && pass;
+ }
+
+ free(version_string);
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
--
1.8.1.4
More information about the Piglit
mailing list