[Piglit] [PATCH v2] core.py: fix subtest json reporting

Dylan Baker baker.dylan.c at gmail.com
Wed Aug 28 12:35:02 PDT 2013


Previously every subtest wrote an entry in the file as a full test, this
is a bug since the fake-fulltest (actually subtest) reported with the
full test value, not it's own value.

This patch changes the behvaior so that a test with subtests only gets
one entry, with the full test result value as it's value.

Signed-off-by: Dylan Baker <baker.dylan.c at gmail.com>
---
 framework/core.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/framework/core.py b/framework/core.py
index b1a5726..25cc2ff 100644
--- a/framework/core.py
+++ b/framework/core.py
@@ -476,9 +476,7 @@ class Test:
                 for test in result['subtest'].keys():
                     if serious_level(result['subtest'][test]) >= serious_level(result['result']):
                         result['result'] = result['subtest'][test]
-                    json_writer.write_dict_item(path + '/' + test, result)
-            else:
-                json_writer.write_dict_item(path, result)
+            json_writer.write_dict_item(path, result)
         else:
             status("dry-run")
 
-- 
1.8.1.5



More information about the Piglit mailing list