[Piglit] [PATCH v2] core.py: fix subtest json reporting

[Eric Anholt]

Tom Stellard <tom at stellard.net> writes:

> On Wed, Aug 28, 2013 at 12:35:02PM -0700, Dylan Baker wrote:
>> Previously every subtest wrote an entry in the file as a full test, this
>> is a bug since the fake-fulltest (actually subtest) reported with the
>> full test value, not it's own value.
>> 
>> This patch changes the behvaior so that a test with subtests only gets
>> one entry, with the full test result value as it's value.
>> 
>
> I would really like the old behavior preserved.  If each subtest doesn't
> have its own entry in the summary, then there is really no point to
> having subtests.
>
> I am having a little trouble following the code, so here are some examples
> of the past and current behavior to help clarify the situation.
>
> Lets say we have a Test A with subtests:
> 1 => 'FAIL'
> 2 => 'PASS'
> 3 => 'FAIL'
>
> The original way of displaying this (i.e before
> eeec306bc2197a2fc0eeb064462a1244d39c16fa) was:
>
> A     2/3
> 1     FAIL
> 2     PASS
> 3     FAIL
>
> The way it is displayed with the current code from git is:
>
> A    0/3
> 1    FAIL
> 2    FAIL
> 3    FAIL
>
> The way it is displayed with this patch is:
>
> A    FAIL
>
> The current state of things is making it difficult to compare subtest results.
> Would anyone object to me reverting eeec306bc2197a2fc0eeb064462a1244d39c16fa
> while we sort out how to best handle subtests?

Yeah, it should definitely be backed out.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130829/579921cc/attachment.pgp>