[Piglit] [PATCH] GL3.3: Test invalid parameters for GL_ARB_texture_rectangle.

Nicholas Mack nichmack at gmail.com
Mon Dec 2 10:40:19 PST 2013


v2: Move test into arb_texture_rectangle folder and change context

v3: Add tests for other invalid params
---
 tests/all.tests                                    |   1 +
 tests/spec/arb_texture_rectangle/CMakeLists.gl.txt |   1 +
 .../texture-base-level-error.c                     | 103 +++++++++++++++++++++
 3 files changed, 105 insertions(+)
 create mode 100644 tests/spec/arb_texture_rectangle/texture-base-level-error.c

diff --git a/tests/all.tests b/tests/all.tests
index cdaf1d5..d427419 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1557,6 +1557,7 @@ add_concurrent_test(arb_texture_rectangle, '1-1-linear-texture')
 add_plain_test(arb_texture_rectangle, 'texrect-many')
 add_concurrent_test(arb_texture_rectangle, 'getteximage-targets RECT')
 add_plain_test(arb_texture_rectangle, 'texrect_simple_arb_texrect')
+add_plain_test(arb_texture_rectangle, 'arb_texrect-texture-base-level-error')
 add_plain_test(arb_texture_rectangle, 'fbo-blit rect')
 
 arb_texture_storage = Group()
diff --git a/tests/spec/arb_texture_rectangle/CMakeLists.gl.txt b/tests/spec/arb_texture_rectangle/CMakeLists.gl.txt
index d84a850..96f04e2 100644
--- a/tests/spec/arb_texture_rectangle/CMakeLists.gl.txt
+++ b/tests/spec/arb_texture_rectangle/CMakeLists.gl.txt
@@ -11,3 +11,4 @@ link_libraries (
 )
 
 piglit_add_executable (texrect_simple_arb_texrect texrect-simple.c)
+piglit_add_executable (arb_texrect-texture-base-level-error texture-base-level-error.c)
diff --git a/tests/spec/arb_texture_rectangle/texture-base-level-error.c b/tests/spec/arb_texture_rectangle/texture-base-level-error.c
new file mode 100644
index 0000000..a0a2e08
--- /dev/null
+++ b/tests/spec/arb_texture_rectangle/texture-base-level-error.c
@@ -0,0 +1,103 @@
+/**
+ * Copyright © 2013 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * Test that when target is TEXTURE_RECTANGLE, the correct error messages are
+ *  generated when certain texture parameter values are specified.
+ *
+ * Section 3.8.8(Texture Parameters) of OpenGL 3.3 Core says:
+ * "When target is TEXTURE_RECTANGLE, certain texture parameter values may
+ *  not be specified. In this case, the error INVALID_ENUM is generated if the
+ *  TEXTURE_WRAP_S, TEXTURE_WRAP_T, or TEXTURE_WRAP_R parameter is set
+ *  to REPEAT or MIRRORED_REPEAT. The error INVALID_ENUM is generated if
+ *  TEXTURE_MIN_FILTER is set to a value other than NEAREST or LINEAR (no
+ *  mipmap filtering is permitted). The error INVALID_VALUE is generated if
+ *  TEXTURE_BASE_LEVEL is set to any value other than zero."
+ *
+ */
+
+#include "piglit-util-gl-common.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+
+	config.supports_gl_core_version = 31;
+	config.supports_gl_compat_version = 10;
+
+PIGLIT_GL_TEST_CONFIG_END
+
+void
+piglit_init(int argc, char **argv)
+{
+	bool pass = true;
+	int i;
+	GLenum invalidWrapParams[] = {GL_REPEAT, GL_MIRRORED_REPEAT};
+	GLenum invalidFilterParams[] = {GL_NEAREST_MIPMAP_NEAREST,
+					GL_NEAREST_MIPMAP_LINEAR,
+					GL_LINEAR_MIPMAP_NEAREST,
+					GL_LINEAR_MIPMAP_LINEAR};
+
+	if(piglit_get_gl_version() < 33)
+		piglit_require_extension("ARB_texture_rectangle");
+
+	/*  the error INVALID_ENUM is generated if the
+	 *  TEXTURE_WRAP_S, TEXTURE_WRAP_T, or TEXTURE_WRAP_R parameter is set
+	 *  to REPEAT or MIRRORED_REPEAT
+	 */
+	for(i = 0; i < ARRAY_SIZE(invalidWrapParams); i++) {
+		glTexParameteri(GL_TEXTURE_RECTANGLE, GL_TEXTURE_WRAP_S,
+					 invalidWrapParams[i]);
+		pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;
+
+		glTexParameteri(GL_TEXTURE_RECTANGLE, GL_TEXTURE_WRAP_T,
+					 invalidWrapParams[i]);
+		pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;
+
+		glTexParameteri(GL_TEXTURE_RECTANGLE, GL_TEXTURE_WRAP_R,
+					 invalidWrapParams[i]);
+		pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;
+	}
+
+	/*  The error INVALID_ENUM is generated if
+	 *  TEXTURE_MIN_FILTER is set to a value other than NEAREST or LINEAR
+	 */
+	for(i = 0; i < ARRAY_SIZE(invalidFilterParams); i++) {
+		glTexParameteri(GL_TEXTURE_RECTANGLE, GL_TEXTURE_MIN_FILTER,
+					 invalidFilterParams[i]);
+		pass = piglit_check_gl_error(GL_INVALID_ENUM) && pass;
+	}
+
+	/*  The error INVALID_VALUE is generated if
+	 *  TEXTURE_BASE_LEVEL is set to any value other than zero
+	 */
+	glTexParameteri(GL_TEXTURE_RECTANGLE, GL_TEXTURE_BASE_LEVEL, 37);
+	pass = piglit_check_gl_error(GL_INVALID_VALUE) && pass;
+
+	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
+
+enum piglit_result
+piglit_display(void)
+{
+	/* UNREACHED */
+	return PIGLIT_FAIL;
+}
-- 
1.8.3.1



More information about the Piglit mailing list