[Piglit] [PATCH 3/3] egl_ext_client_extensions: Add initial tests

Chad Versace chad.versace at linux.intel.com
Wed Dec 4 10:52:00 PST 2013


On 12/03/2013 07:42 PM, Matt Turner wrote:
> On Tue, Nov 26, 2013 at 12:46 PM, Chad Versace
> <chad.versace at linux.intel.com> wrote:
>> Add tests for the conformance tests listed in the
>> EGL_EXT_client_extensions spec.
>>
>> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
>> ---
>>   tests/all.tests                                    |   5 +
>>   tests/egl/spec/CMakeLists.txt                      |   1 +
>>   .../CMakeLists.no_api.txt                          |   7 +
>>   .../spec/egl_ext_client_extensions/CMakeLists.txt  |   1 +
>>   .../egl_ext_client_extensions.c                    | 227 +++++++++++++++++++++
>>   5 files changed, 241 insertions(+)
>>   create mode 100644 tests/egl/spec/egl_ext_client_extensions/CMakeLists.no_api.txt
>>   create mode 100644 tests/egl/spec/egl_ext_client_extensions/CMakeLists.txt
>>   create mode 100644 tests/egl/spec/egl_ext_client_extensions/egl_ext_client_extensions.c


>
> Don't the printfs cause piglit summary generation to interpret passes
> as warns? Or maybe it's just fprintf to stderr.

Printing to stdout is fine. Printing to stderr causes a warning.



>> +/**
>> + * Conformance test #2 in the EGL_EXT_client_extensions spec:
>> + *
>> + *    2. Obtain a display with eglGetDisplay but do not initialize it. Verity
>
> Verify

Fixed.


> All three are
>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>


Thanks.



More information about the Piglit mailing list