[Piglit] [PATCH] glsl-1.20: Negative test redeclaration of gl_TexCoord

Ian Romanick idr at freedesktop.org
Thu Dec 5 11:28:48 PST 2013


I'd change the name of the test to gl_TexCoord-redeclaration-too-big in
case we add similar tests for other built-in variables.  It seems like
we might have a similar test for gl_ClipDistance in tests/spec/glsl-1.30.

With that changed, the test is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 12/01/2013 01:51 PM, Timothy Arceri wrote:
> Signed-off-by: Timothy Arceri <t_arceri at yahoo.com.au>
> ---
>  .../array-builtin-redeclaration-too-big.vert              | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-builtin-redeclaration-too-big.vert
> 
> diff --git a/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-builtin-redeclaration-too-big.vert b/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-builtin-redeclaration-too-big.vert
> new file mode 100644
> index 0000000..5e4f994
> --- /dev/null
> +++ b/tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-builtin-redeclaration-too-big.vert
> @@ -0,0 +1,15 @@
> +/* [config]
> + * expect_result: fail
> + * glsl_version: 1.20
> + * [end config]
> + *
> + * From page 54 (page 60 of the PDF) of the GLSL 1.20 spec:
> + *
> + *     "The size [of gl_TexCoord] can be at most
> + *     gl_MaxTextureCoords."
> + */
> +#version 120
> +
> +varying vec4 gl_TexCoord[gl_MaxTextureCoords+1];
> +
> +void main() { gl_Position = vec4(0.0); }
> 



More information about the Piglit mailing list