[Piglit] [PATCH] glsl-1.20: Test sizing an array by initialization after the array has been accessed

Timothy Arceri t_arceri at yahoo.com.au
Sun Dec 8 00:57:46 PST 2013


On Fri, 2013-12-06 at 08:54 -0800, Ian Romanick wrote:
> On 12/05/2013 02:08 PM, Timothy Arceri wrote:
> > Reviewed-by: Timothy Arceri <t_arceri at yahoo.com.au>
> > 
> > Only small issue is the "too small" commit message could do with some
> > rewording.
> 
> Yeah... the wording for both was fairly rubbish.  I started writing it
> one way, but, when I decided to copy-and-paste, partially changed the
> wording.  I've changed this to:
> 
> glsl-1.20: Test sizing an array by initialization after the array has
> been accessed
> 
> The "big-enough" test verifies that the compiler accepts an initializer
> used to size an array after an access (to the previously implicitly
> sized array) has been seen when the access would have been in-bounds in
> the sized array.
> 
> The "too-small" test verifies that the compiler rejects an initializer
> used to size an array after an access (to the previously implicitly
> sized array) has been seen when the access would have been out-of-bounds
> in the sized array.

This is much easier to read thanks.




More information about the Piglit mailing list