[Piglit] [PATCH] glBeginConditionalRenderNV begin zero

Jin Zhou zhoujin10 at gmail.com
Tue Dec 10 04:08:45 PST 2013


From: Jin Zhou <jin.zhou at amd.com>

a INVALID_VALUE error should be genrated, instead of INVALID_OPERATION

---
 tests/spec/nv_conditional_render/begin-zero.c |   13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)
 mode change 100644 => 100755 tests/spec/nv_conditional_render/begin-zero.c

diff --git a/tests/spec/nv_conditional_render/begin-zero.c b/tests/spec/nv_conditional_render/begin-zero.c
old mode 100644
new mode 100755
index 3d85b92..c898499
--- a/tests/spec/nv_conditional_render/begin-zero.c
+++ b/tests/spec/nv_conditional_render/begin-zero.c
@@ -27,17 +27,12 @@
  * @file begin-zero.c
  *
  * Tests that starting conditional rendering on a 0 query object
- * results in INVALID_OPERATION.
+ * results in INVALID_VALUE.
  *
  * From the NV_conditional_render spec:
  *
- *     "BeginQuery sets the active query object name for the query
- *      type given by <target> to <id>.  If BeginQuery is called with
- *      an <id> of zero, if the active query object name for <target>
- *      is non-zero, if <id> is the active query object name for any
- *      query type, or if <id> is the active query object for
- *      condtional rendering (Section 2.X), the error INVALID
- *      OPERATION is generated."
+ *     "INVALID_VALUE is generated by BeginConditionalRenderNVX if <id> is not the
+ *       name of an existing occlusion query object."
  */
 
 PIGLIT_GL_TEST_CONFIG_BEGIN
@@ -64,7 +59,7 @@ piglit_init(int argc, char **argv)
 	piglit_require_extension("GL_NV_conditional_render");
 
 	glBeginConditionalRenderNV(0, GL_QUERY_WAIT_NV);
-	if (!piglit_check_gl_error(GL_INVALID_OPERATION))
+	if (!piglit_check_gl_error(GL_INVALID_VALUE))
 		piglit_report_result(PIGLIT_FAIL);
 
 	piglit_report_result(PIGLIT_PASS);
-- 
1.7.9.5



More information about the Piglit mailing list