[Piglit] [PATCH] fix the fbo bind error check. a GL_INVALID_OPERATION error should be generated, instead of GL_INVALID_VALUE

Zhou, Jin Jin.Zhou at amd.com
Tue Dec 10 20:03:26 PST 2013


Sorry, this patch is incorrect.  I have send the correct one. Please ignore it.

From: Ken Phillis Jr [mailto:kphillisjr at gmail.com]
Sent: Wednesday, December 11, 2013 11:36 AM
To: Jin Zhou
Cc: piglit at lists.freedesktop.org; Zhou, Jin
Subject: Re: [Piglit] [PATCH] fix the fbo bind error check. a GL_INVALID_OPERATION error should be generated, instead of GL_INVALID_VALUE

I think this patch needs to be reworked. I believe there should be more than just adding a blank line.

On Mon, Dec 9, 2013 at 4:44 AM, Jin Zhou <zhoujin10 at gmail.com<mailto:zhoujin10 at gmail.com>> wrote:
From: Jin Zhou<jin.zhou at amd.com<mailto:jin.zhou at amd.com>>

diff --git a/tests/fbo/fbo-bind-renderbuffer.c b/tests/fbo/fbo-bind-renderbuffer.c
index 50c8c7f..3b2b305 100644
--- a/tests/fbo/fbo-bind-renderbuffer.c
+++ b/tests/fbo/fbo-bind-renderbuffer.c
@@ -64,6 +64,7 @@ test_binding(GLboolean bindRenderbuffer)
                                 GL_RENDERBUFFER_EXT, rb);

    err = glGetError();
+
    return err;
 }

--
1.7.9.5

_______________________________________________
Piglit mailing list
Piglit at lists.freedesktop.org<mailto:Piglit at lists.freedesktop.org>
http://lists.freedesktop.org/mailman/listinfo/piglit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20131211/6c5c87f1/attachment.html>


More information about the Piglit mailing list