[Piglit] [PATCH 0/8 v2] Support creation of debug and forward-compatible contexts

[Chad Versace]

On Mon, Dec 30, 2013 at 07:42:27PM +1100, Timothy Arceri wrote:
> Here is some feedback from my testing with AMD Catalyst drivers. As
> previously discussed they seem to be missing GLX_ARB_create_context
> extension is from "server glx extensions"
> 
> With V1 on Catalyst I got:
> 
> piglit: info: Failed to create GL 1.0 compatibility context
> piglit: info: Failed to create any GL context
> PIGLIT: {'result': 'skip' }
> 
> With this version I'm getting:
> 
> piglit: error: waffle_config_choose failed due to
> WAFFLE_ERROR_BAD_ATTRIBUTE: unrecognized attribute 0x216 at
> attrib_list[6]
> piglit: error: Failed to create waffle_config for OpenGL 1.0 Debug
> Context
> piglit: info: Failed to create any GL context

I'm glad I improved Piglit's error messages. After some investigation, I
diagnosed the failure.

Attribute 0x0216 is WAFFLE_CONTEXT_DEBUG (see waffle.h), which is introduced in
waffle-1.3.0. So you have an earlier version of waffle installed. Most likely,
you have waffle-1.2.

But! Patch 1 of this series changes Piglit's CMakeLists.txt to require
waffle-1.3.0. So... how were you able to build Piglit? Why didn't CMake fail
due to the unsatisfied dependency?

Because CMake is stupid sometimes :(

I've sent a v3 series to the list. The only difference between v2 and v3 is that
v3-patch1 attempts to workaround a deficiency in CMake dependency validation.