[Piglit] [PATCH 0/7] RFC: Add Android Support via Android.mk

[Chad Versace]

On 02/02/2013 07:33 AM, Tom Gall wrote:
> On Sat, Feb 2, 2013 at 12:02 AM, Eric Anholt <eric at anholt.net> wrote:
>> Tom Gall <tom.gall at linaro.org> writes:
>>
>>> This patch series builds piglit within the Android source tree. It's
>>> still a bit of a work in progress but the build succeeds and the tests
>>> that are built do pass.
>>>
>>> The 3rd patch is entirely written by Adrian M Negreanu and really is
>>> the heart of the Android implementation for piglit as it adds the
>>> framework support without which nothing would work.
>>>
>>> If anything these patches that create the various Android.mk files are
>>> but the strings that hold together Adrian's bouquet. They allow for
>>> piglit to build as part of an Android image build which is quite handy
>>> for validation farms and such.
>>>
>>> While this patch series uses multiple Android.mk files, one could
>>> implement all of this is one large Android.mk at the top level
>>> directory.
>>
>> Instead of cooking up a brand new build system that will always be
>> terribly maintained, it looks like there are a number of
>> cmake-for-android projects out there.  Have you exhausted all of those
>> as possibilities for sure?
> 
> I entirely understand your concern. I understand that having two build
> systems around can be viewed as being less than ideal. I did not take
> this step lightly nor was it a thought influenced by appreciation of
> one build system over the other.
> 
> Consider:
> 
> Within AOSP the projects that utilize cmake don't use it for Android,
> rather they use the Android build system. llvm, libpng, sysbench,
> jpeg, clang, libbcc as a for instance.
> 
> Waffle uses the Android build system.
> 
> Mesa uses the Android build system.
> 
> Those coming from the world of Android when contributing know the
> Android build system so there is a talent pool. Likewise when working
> with Android, you have to know the Android build system.
> 
> When building piglit (&waffle) for Android, one will always have to be
> in the presence of the whole android setup with certain portions of
> that source tree already built in order for it to work.
> 
> I (or one of my team) can/will happily maintain this. Piglit is very
> important to us long term on both Android and Linux.


I'm afraid that if we have truly separate build systems for Piglit, then
one build will frequently be broken. Very frequently. It's a maintenance burden
that I would like to avoid.

I'm hoping that there exists a solution that adds only a toplevel Android.mk
to Piglit, and the Android.mk simply invokes CMake and then calls make. I
expect that, using Adrian's patches from Nov 16, it is possible to do this.
Adrian's patches add the necessary cmake files to inform cmake how to use
the Android toolchain; all that is lacking is the toplevel Android.mk that
calls into cmake.

Maybe I'm hoping for something that's impossible. And if it's impossible,
we should figure out a way to make it un-impossible.