[Piglit] Fwd: [PATCH 1/2] port ttexrect.cpp to piglit from glean
brianp at vmware.com
Thu Feb 7 07:04:13 PST 2013
LGTM. Are you asking for another review or do you need someone to
commit/push it for you?
On 02/06/2013 03:38 PM, Tom Gall wrote:
> It was a little over two weeks ago when v2 of these 2 patches to port
> ttexrect to piglit and remove it from glean were posted.
> It has a Reviewed-by: Brian Paul<brianp at vmware.com>
> Any reason why this shouldn't go in?
> ---------- Forwarded message ----------
> From: Brian Paul<brianp at vmware.com>
> Date: Mon, Jan 21, 2013 at 4:46 PM
> Subject: Re: [Piglit] [PATCH 1/2] port ttexrect.cpp to piglit from glean
> To: Tom Gall<tom.gall at linaro.org>
> Cc: piglit at lists.freedesktop.org, patches at linaro.org
> On 01/21/2013 01:43 PM, Tom Gall wrote:
>> This ported test goes into tests/spec/arb_texture_rectangle. It
>> tests the ARB_texture_rectangle extension.
>> Create a 255x127 texture of varying colors and bind it as a
>> GL_ARB_texture_recangle target. Draw that rectangle to the window, and
>> check that the texture was drawn correctly. The common failure to be
>> caught with this test is not adjusting the non-normalized coordinates on
>> hardware that expects normalized coordinates.
>> To all.tests, add new texrect_simple_arb_texrect
>> v2: add PIGLIT_GL_VISUAL_DOUBLE to the window_visual, move various
>> setup bits to piglit_init and add forgotten all.tests change.
>> Signed-off-by: Tom Gall<tom.gall at linaro.org>
> For both:
> Reviewed-by: Brian Paul<brianp at vmware.com>
> "Where's the kaboom!? There was supposed to be an earth-shattering
> kaboom!" Marvin Martian
> Tech Lead, Graphics Working Group | Linaro.org │ Open source software
> for ARM SoCs
> w) tom.gall att linaro.org
> h) tom_gall att mac.com
> Piglit mailing list
> Piglit at lists.freedesktop.org
More information about the Piglit