[Piglit] [PATCH 1/6] shader_runner and glslparsertest: choose GL version more accurately.
eric at anholt.net
Mon Feb 18 11:50:55 PST 2013
Paul Berry <stereotype441 at gmail.com> writes:
> On 18 February 2013 07:53, Michel Dänzer <michel at daenzer.net> wrote:
>> On Don, 2013-02-14 at 08:50 -0800, Paul Berry wrote:
>> > Previously, both shader_runner and glslparsertest contained switch
>> > statements that attempted to choose a GL version for testing based on
>> > a GLSL version requirement, and those switch statements didn't choose
>> > a GL version very accurately (for example, they converted GLSL version
>> > 1.50 to GL version 3.1, which doesn't work).
>> > This patch replaces the switch statements with a single common
>> > function (in piglit-util-gl-common) that does the right thing.
>> This change caused quick-driver.tests to skip more than 2000 tests on
>> radeonsi (GL 2.1, GLSL 1.2). Almost all of the skipped tests were
>> previously passing.
>> Was this intended?
> No, this wasn't expected, and probably indicates a bug in the driver.
> The specific behavioural change in Piglit is that previously, when running
> a test that required GLSL 1.20, Piglit would request (via Waffle) a GL 1.0
> context. Then it would query the context to see if it supported GLSL
> 1.20. After this patch, when running a test that requires GLSL 1.20,
> Piglit requests a GL 2.1 context, and then skips if a GL 2.1 context can't
> be created. On an implementation that supports GL 2.1 and GLSL 1.20, both
> methods should yield the same results.
But what about an implementation that does GLSL 1.20 but not GL 2.1? Or
GLSL 1.30 but not all of GL 3.1?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 197 bytes
Desc: not available
More information about the Piglit