[Piglit] [PATCH] ARB_uniform_buffer_object/row_major: Reference another missed UBO member.

Ian Romanick idr at freedesktop.org
Tue Feb 19 20:12:42 PST 2013


On 02/19/2013 11:40 AM, Eric Anholt wrote:
> Makes the test pass on Mesa master.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59957

With the spurious hunk removed,

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

Since I wrote the exact same patch at about the exact same time. :(

> ---
>   tests/gtf.tests                                  |    2 +-
>   tests/spec/arb_uniform_buffer_object/row-major.c |    1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/gtf.tests b/tests/gtf.tests
> index 4cbbd2c..2a72ef8 100644
> --- a/tests/gtf.tests
> +++ b/tests/gtf.tests
> @@ -42,7 +42,7 @@ if not os.path.exists(os.path.join(testBinDir, 'GTF')):
>   gtfroot = path.dirname(path.realpath(path.join(testBinDir, 'GTF')))
>
>   class GTFTest(ExecTest):
> -    pass_re = re.compile(r'Regression PASSED all 1 tests')
> +    pass_re = re.compile(r'(Regression|Conformance) PASSED all 1 tests')
>
>       def __init__(self, testpath):
>           ExecTest.__init__(self, [path.join(testBinDir, 'GTF'), '-width=113', '-height=47', '-seed=2', '-minfmt', '-run=' + testpath])
> diff --git a/tests/spec/arb_uniform_buffer_object/row-major.c b/tests/spec/arb_uniform_buffer_object/row-major.c
> index 7e3425a..d2269c7 100644
> --- a/tests/spec/arb_uniform_buffer_object/row-major.c
> +++ b/tests/spec/arb_uniform_buffer_object/row-major.c
> @@ -124,6 +124,7 @@ static const char *source =
>   	"		non_mat + \n"
>   	"		a_cm1[0] + \n"
>   	"		a_cm2[0] + \n"
> +	"		a_rm1[0] + \n"
>   	"		a_cm3[0] + \n"
>   	"		b_cm1[0] + \n"
>   	"		b_rm1[0] + \n"
>



More information about the Piglit mailing list