[Piglit] [PATCH 1/6] glean/pixelformats: Initialize PixelFormatsTest member variables.

Vinson Lee vlee at freedesktop.org
Tue Jan 1 16:49:57 PST 2013


Fixes uninitialized scalar field defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 tests/glean/tpixelformats.h | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/tests/glean/tpixelformats.h b/tests/glean/tpixelformats.h
index 20641fe..d0edb94 100644
--- a/tests/glean/tpixelformats.h
+++ b/tests/glean/tpixelformats.h
@@ -42,15 +42,18 @@ class PixelFormatsTest: public MultiTest
 {
 public:
 	PixelFormatsTest(const char* testName, const char* filter,
-					 const char *extensions, const char* description)
-		: MultiTest(testName, filter, extensions, description)
+					 const char *extensions, const char* description):
+		MultiTest(testName, filter, extensions, description),
+		alphaBits(0),
+		defaultAlpha(0),
+		haveHalfFloat(false),
+		haveABGR(false),
+		haveSRGB(false),
+		haveCombine(false),
+		haveRG(false),
+		haveSnorm(false),
+		haveTexSharedExp(false)
 	{
-		alphaBits = 0;
-		defaultAlpha = 0;
-		haveHalfFloat = false;
-		haveABGR = false;
-		haveSRGB = false;
-		haveCombine = false;
 	}
 
 	virtual void runOne(MultiTestResult &r, Window &w);
-- 
1.8.0.2



More information about the Piglit mailing list