[Piglit] [PATCH 3/3] Add tests for glCompressedTex{Image, SubImage}3D().

[Ian Romanick]

On 01/03/2013 02:39 PM, Eric Anholt wrote:
> Paul Berry <stereotype441 at gmail.com> writes:
>> +#ifdef PIGLIT_USE_OPENGL
>> +#define GRAYSCALE_IMAGES piglit_fxt1_grayscale_images
>> +#define COMPRESSED_FORMAT GL_COMPRESSED_RGB_FXT1_3DFX
>
> FXT1 does mean that non-intel drivers won't run this test.  Not
> objecting, just noting that.
>
>> +#define GLSL_VERSION "120"
>
> It seems like some of the ifdefs below in this test could go away by
> just requiring 130.  Does anyone do arrays but not 130?

We do on Ironlake and earlier. :)

>> +static const char vs_text[] =
>> +	"#version " GLSL_VERSION "\n"
>
> Maybe fold GLSL_VERSION into the ifdefs instead of ifdeffing it above?
>
>> +#ifdef PIGLIT_USE_OPENGL
>> +	"#define piglit_Vertex gl_Vertex\n"
>> +	"#define piglit_MultiTexCoord0 gl_MultiTexCoord0\n"
>> +	"#define piglit_in attribute\n"
>> +	"#define piglit_out varying\n"
>> +#else // PIGLIT_USE_OPENGL_ES3
>> +	"#define piglit_in in\n"
>> +	"#define piglit_out out\n"
>> +	"piglit_in vec4 piglit_Vertex;\n"
>> +	"piglit_in vec4 piglit_MultiTexCoord0;\n"
>> +#endif
>>
>>
>> _______________________________________________
>> Piglit mailing list
>> Piglit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/piglit