[Piglit] [PATCH 1/1] shader_runner: add gles2 support and simple testcase

[Chad Versace]

On 12/28/2012 02:26 PM, Tom Gall wrote:
> Fix shader_test.py so it uses shader_runner_gles2 when running
> a shader test with GL 2.00 es in the [required] section.
                     ^^^^^^^^^^
It should be "GL 2.0 es". Though, shader_runner accepts "GL 2.00 es"
because it's sloppy.

Otherwise, the sub-commit for shader_test.py looks good. It has
my reviewed-by, but please separate it into its own commit.

> In shader_runner.c set config.supports_gl_es_version = 20 when
> PIGLIT_USE_OPENGL_ES2 is defined.

The sub-commit for shader_runner.c is unnecessary. shader_runner
sets config.suports_gl_es_version = 20 in get_required_versions()
when the test's requirement block contains `GL >= 2.0 es`.

> Add a number of GLES2 specific workarounds to
> shader_runner_gles_workarounds.h.

This sub-commit for shader_runer_gles_workarounds.h looks good.
It has my reviewed-by, but please separate it its own commit.
 
> Add tests/spec/glsl-es-1.00 directory and new
> execution/sanity.shader_test in that directory.

Comments below for sanity.shader_test.

 
> Signed-off-by: Tom Gall <tom.gall at linaro.org>
> ---
>  framework/shader_test.py                           |    4 +-
>  tests/shaders/shader_runner.c                      |    3 ++
>  tests/shaders/shader_runner_gles_workarounds.h     |   52 ++++++++++++++++++--
>  .../spec/glsl-es-1.00/execution/sanity.shader_test |   44 +++++++++++++++++
>  4 files changed, 96 insertions(+), 7 deletions(-)
>  create mode 100644 tests/spec/glsl-es-1.00/execution/sanity.shader_test


> diff --git a/tests/spec/glsl-es-1.00/execution/sanity.shader_test b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> new file mode 100644
> index 0000000..631757a
> --- /dev/null
> +++ b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> @@ -0,0 +1,44 @@


> +[fragment shader]
> +#version 100
> +
> +uniform vec4 u_color;
> +vec4 color;

`color` is defined but not used.

Otherwise, the sanity.shader_test sub-commit has my reviewed-by,
but please separate it into its own commit.