[Piglit] [PATCH 2/7] Cleanup occlusion-query test to not require function pointers.

Eric Anholt eric at anholt.net
Thu Jan 10 14:23:55 PST 2013

Carl Worth <cworth at cworth.org> writes:

> With the current piglit dispatch code, the distinction between things
> like glBeginQuery and glBeginQueryARB is taken care of already so the
> test can be simplified a bit.

> +	if (piglit_get_gl_version() < 15 &&
> +	    ! piglit_is_extension_supported("GL_ARB_occlusion_query"))
> +	{
>  		piglit_report_result(PIGLIT_SKIP);
>  	}

This block could just be
piglit_require_extension("GL_ARB_occlusion_query") -- I think all
implementations of 1.5+ still expose ARB_oq.

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130110/45835803/attachment.pgp>

More information about the Piglit mailing list