[Piglit] [PATCH] ext_framebuffer_multisample-negative-readpixels: Remove unused variable.

Brian Paul brianp at vmware.com
Mon Jan 14 07:24:55 PST 2013


On 01/10/2013 11:43 PM, Vinson Lee wrote:
> Fixes logically dead code defect reported by Coverity.
>
> Signed-off-by: Vinson Lee<vlee at freedesktop.org>
> ---
>   tests/spec/ext_framebuffer_multisample/negative-readpixels.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/spec/ext_framebuffer_multisample/negative-readpixels.c b/tests/spec/ext_framebuffer_multisample/negative-readpixels.c
> index 1152a4c..09c8735 100644
> --- a/tests/spec/ext_framebuffer_multisample/negative-readpixels.c
> +++ b/tests/spec/ext_framebuffer_multisample/negative-readpixels.c
> @@ -59,7 +59,6 @@ piglit_init(int argc, char **argv)
>   	GLint max_samples;
>   	GLuint rb, fb;
>   	GLenum status;
> -	bool pass = true;
>   	float data[4];
>
>   	piglit_require_extension("GL_EXT_framebuffer_multisample");
> @@ -94,5 +93,5 @@ piglit_init(int argc, char **argv)
>   	glDeleteRenderbuffersEXT(1,&rb);
>   	glDeleteFramebuffersEXT(1,&fb);
>
> -	piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
> +	piglit_report_result(PIGLIT_PASS);
>   }


Reviewed-by: Brian Paul <brianp at vmware.com>


More information about the Piglit mailing list