[Piglit] [PATCH 1/2] arb_texture_buffer_object: New test for sampling outside of the buffer.
Eric Anholt
eric at anholt.net
Mon Jan 14 11:31:55 PST 2013
---
tests/all.tests | 1 +
.../arb_texture_buffer_object/CMakeLists.gl.txt | 1 +
.../fetch-outside-bounds.c | 145 ++++++++++++++++++++
3 files changed, 147 insertions(+)
create mode 100644 tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c
diff --git a/tests/all.tests b/tests/all.tests
index 145312c..88f009e 100644
--- a/tests/all.tests
+++ b/tests/all.tests
@@ -1095,6 +1095,7 @@ arb_texture_buffer_object['formats (VS, 3.1 core)'] = concurrent_test('arb_textu
arb_texture_buffer_object['formats (FS, ARB)'] = concurrent_test('arb_texture_buffer_object-formats fs arb')
arb_texture_buffer_object['formats (VS, ARB)'] = concurrent_test('arb_texture_buffer_object-formats vs arb')
arb_texture_buffer_object['get'] = concurrent_test('arb_texture_buffer_object-get')
+arb_texture_buffer_object['fetch-outside-bounds'] = concurrent_test('arb_texture_buffer_object-fetch-outside-bounds')
arb_texture_buffer_object['minmax'] = concurrent_test('arb_texture_buffer_object-minmax')
arb_texture_buffer_object['negative-bad-bo'] = concurrent_test('arb_texture_buffer_object-negative-bad-bo')
arb_texture_buffer_object['negative-bad-format'] = concurrent_test('arb_texture_buffer_object-negative-bad-format')
diff --git a/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt b/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt
index 05d2a54..67213da 100644
--- a/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt
+++ b/tests/spec/arb_texture_buffer_object/CMakeLists.gl.txt
@@ -18,3 +18,4 @@ piglit_add_executable (arb_texture_buffer_object-negative-bad-bo negative-bad-bo
piglit_add_executable (arb_texture_buffer_object-negative-bad-format negative-bad-format.c)
piglit_add_executable (arb_texture_buffer_object-negative-bad-target negative-bad-target.c)
piglit_add_executable (arb_texture_buffer_object-unused-name unused-name.c)
+piglit_add_executable (arb_texture_buffer_object-fetch-outside-bounds fetch-outside-bounds.c)
diff --git a/tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c b/tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c
new file mode 100644
index 0000000..ba26f98
--- /dev/null
+++ b/tests/spec/arb_texture_buffer_object/fetch-outside-bounds.c
@@ -0,0 +1,145 @@
+/* Copyright © 2012 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/** @file fetch-outside-bounds.c
+ *
+ * Tests that we can sample from outside of a texture buffer object
+ * without crashing.
+ *
+ * From the GL_ARB_texture_buffer_object spec:
+ *
+ * "When a buffer texture is accessed in a shader, the results of
+ * a texel fetch are undefined if the specified texel number is
+ * greater than or equal to the clamped number of texels in the
+ * texel array."
+ *
+ * we interpret this as allowing any result to come back, but not
+ * terminate the program. To test that, we glReadPixels the result
+ * but don't test the values returned.
+ */
+
+#include "piglit-util-gl-common.h"
+
+enum piglit_result
+piglit_display(void)
+{
+ static const char *vs_source =
+ "#version 140\n"
+ "in vec4 vertex;\n"
+ "void main()\n"
+ "{\n"
+ " gl_Position = vertex;\n"
+ "}\n";
+
+ static const char *fs_source =
+ "#version 140\n"
+ "uniform samplerBuffer s;\n"
+ "void main()\n"
+ "{\n"
+ " gl_FragColor = texelFetch(s, 4096);\n"
+ "}\n";
+
+ GLuint tex, tbo, vbo;
+ /* data stored in our TBO, not actually read by the shader. */
+ static const uint8_t data[4] = {0x0, 0xff, 0x0, 0x0};
+ uint8_t junk[4];
+ static const GLfloat verts[8] = {
+ -1, -1,
+ 1, -1,
+ 1, 1,
+ -1, 1
+ };
+ int vertex_location;
+ GLuint fs, vs, prog;
+
+ vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vs_source);
+ fs = piglit_compile_shader_text(GL_FRAGMENT_SHADER, fs_source);
+ if (!vs || !fs)
+ piglit_report_result(PIGLIT_FAIL);
+
+ prog = piglit_link_simple_program(vs, fs);
+ if (!prog)
+ piglit_report_result(PIGLIT_FAIL);
+ glUseProgram(prog);
+
+ vertex_location = glGetAttribLocation(prog, "vertex");
+
+ glGenBuffers(1, &tbo);
+ glBindBuffer(GL_TEXTURE_BUFFER, tbo);
+
+ glGenTextures(1, &tex);
+ glBindTexture(GL_TEXTURE_BUFFER, tex);
+
+ glTexBuffer(GL_TEXTURE_BUFFER, GL_RGBA8, tbo);
+ glBufferData(GL_TEXTURE_BUFFER, sizeof(data), data, GL_STATIC_READ);
+
+ if (piglit_get_gl_version() >= 31) {
+ GLuint vao;
+ glGenVertexArrays(1, &vao);
+ glBindVertexArray(vao);
+ }
+ glGenBuffers(1, &vbo);
+ glBindBuffer(GL_ARRAY_BUFFER, vbo);
+ glBufferData(GL_ARRAY_BUFFER, sizeof(verts), verts, GL_STATIC_READ);
+ glVertexAttribPointer(vertex_location, 2, GL_FLOAT,
+ GL_FALSE, 0, NULL);
+ glEnableVertexAttribArray(vertex_location);
+ glDrawArrays(GL_TRIANGLE_FAN, 0, 4);
+
+ glReadPixels(0, 0, 1, 1, GL_RGBA, GL_UNSIGNED_BYTE, &junk);
+ /* We don't verify the junk read, since it's undefined. */
+
+ piglit_present_results();
+
+ return PIGLIT_PASS;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+ piglit_require_GLSL_version(140);
+ if (piglit_get_gl_version() < 31)
+ piglit_require_extension("GL_ARB_texture_buffer_object");
+}
+
+int
+main(int argc, char *argv[])
+{
+ struct piglit_gl_test_config config;
+
+ piglit_gl_test_config_init(&config);
+
+ config.init = piglit_init;
+ config.display = piglit_display;
+
+ config.supports_gl_compat_version = 10;
+ config.supports_gl_core_version = 31;
+
+ config.window_width = 10;
+ config.window_height = 10;
+ config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_ALPHA;
+
+ piglit_gl_test_run(argc, argv, &config);
+
+ assert(false);
+ return 0;
+}
--
1.7.10.4
More information about the Piglit
mailing list