[Piglit] [PATCH] glsl-1.50: add tests for gl_FragCoord layout parameters

Dave Airlie airlied at gmail.com
Mon Jan 14 13:49:58 PST 2013

On Tue, Jan 15, 2013 at 5:00 AM, Paul Berry <stereotype441 at gmail.com> wrote:
> On 13 January 2013 20:11, Dave Airlie <airlied at gmail.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>> These are promoted from GL_ARB_fragment_coord_conventions.
>> GLSL 1.50 add two layout parameters for gl_FragCoord,
>> test them on their own, and in combination.
> In general, for cases like this, I prefer to create a shader_runner
> execution test so that we can test that the feature under test compiles
> *and* executes correctly.  Can we do that for these tests?

These are already covered execution wise by the
ARB_fragment_coord_conventions tests, or at least should be, I think
for GLSL bumps just checking the compiler shuold be enough.

> I feel similarly about the two patches that follow ("glsl-1.50: check
> compiler accepts gl_PrimitiveID for fragment shader" and "glsl-1.50: add
> test for core profile argument to version").

Well the first probably requires geometry shaders to do exec, the
second I don't think execution makes much sense, as having the core
added makes no difference, it jsut has to be accepted by the compiler.


More information about the Piglit mailing list