[Piglit] [PATCH 04/15] fbo-blending-formats: Report subtest results.

Carl Worth cworth at cworth.org
Thu Jan 17 15:51:14 PST 2013

Eric Anholt <eric at anholt.net> writes:
> -	printf("Testing %s", format->name);
>  	if (status != GL_FRAMEBUFFER_COMPLETE_EXT) {
> -		printf(" - fbo incomplete (status = 0x%04x)\n", status);
> +		printf("fbo incomplete (status = 0x%04x)\n", status);
> +		piglit_report_subtest_result(PIGLIT_SKIP, format->name);
>  		return PIGLIT_SKIP;
>  	}
> -        printf("\n");

The patch should be updated to not remove these printf calls.

Without these, it's really hard to distinguish which portions of the
test output correspond to which formats. (At least, that's the case in
the HTML output where the piglit report lines have been stripped out.)

Similarly for fbo-colormask-formats and fbo-alphatest-formats, (and
presumably others, but those are the ones I've actually looked at).

With that change, these patches get my:

Reviewed-by: Carl Worth <cworth at cworth.org>

And it's very helpful, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130117/df5940e5/attachment.pgp>

More information about the Piglit mailing list