[Piglit] [PATCH 1/3] clipflat: glean clipFlat test ported to piglit

[Eric Anholt]

Brian Paul <brianp at vmware.com> writes:

> v2: use piglit_report_subtest_result().

> diff --git a/tests/general/clipflat.c b/tests/general/clipflat.c
> new file mode 100644
> index 0000000..122e206
> --- /dev/null
> +++ b/tests/general/clipflat.c
> @@ -0,0 +1,536 @@
> +/*
> + * Copyright © 2013 VMware, Inc.

2009, 2013? :)

> +	snprintf(msg3, sizeof(msg3),
> +		 "\tExpected color (0, 1, 0) but found (%g, %g, %g)\n",
> +		 badColor[0], badColor[1], badColor[2]);
> +	

trailing whitespace

> +	snprintf(msg, sizeof(msg), "%s%s%s", msg1, msg2, msg3);
> +
> +	piglit_report_subtest_result(PIGLIT_FAIL, msg);

You can just say:

piglit_report_subtest_result(PIGLIT_FAIL, "%s%s%s", msg1, msg2, msg3);

now.  Other than that, the series is
Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130122/5fcaa378/attachment.pgp>