[Piglit] [PATCH] arb_uniform_buffer_object: Fix tests with clarifications from Khronos

Eric Anholt eric at anholt.net
Tue Jan 22 11:29:22 PST 2013

Ian Romanick <idr at freedesktop.org> writes:

> From: Ian Romanick <ian.d.romanick at intel.com>
> OpenGL ES 3.0 (and presumably other versions of OpenGL) have two
> requirements that these tests expect to be violated:
> 1. Members of a uniform block that are not used will not be marked
> active.
> 2. It is an error to apply a row_major or column_major layout qualifier
> to a non-matirx type.
> These changes fix the UBO tests to actually use all of the members of
> each block and not use row_major and column_major layout qualifiers on
> non-matrix types.
> Without these fixes, a patch series that is going out to the mesa-dev
> list very soon that fixes many gles3conform failures will regress these
> tests.

This commit is two commits plus some other garbage all smashed together.

I thought what I did was a pretty obvious interpretation of the
ARB_uniform_buffer_object spec, but there's room for both of these
changes I guess.  I don't know of any UBO apps to test with to see if
anybody regresses from throwing a new error on inappropriate
row_major/column_major, so we're probably safe.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20130122/38ce8738/attachment.pgp>

More information about the Piglit mailing list