[Piglit] [PATCH] ext_framebuffer_multisample: check for num_samples<=1
brian.e.paul at gmail.com
Sun Jan 27 08:07:17 PST 2013
On Sun, Jan 27, 2013 at 2:51 AM, Eric Anholt <eric at anholt.net> wrote:
> Brian Paul <brianp at vmware.com> writes:
>> Even if GL_ARB_multisample is advertised, it's OK for the max number of
>> samples to be zero.
> Huh? The EXT_framebuffer_multisample spec says minmax of MAX_SAMPLES is
And GL_ARB_framebuffer_object says it's zero.
It looks like the piglit test is checking the wrong extension. At
line 364 we're calling
piglit_require_extension("GL_ARB_framebuffer_object"). I don't see
any checks for GL_EXT_framebuffer_multisample. I was looking at
GL_MAX_SAMPLES in the former, not the later.
I guess the proper fix is to just check for the proper extension.
More information about the Piglit