[Piglit] [PATCH] glx-multithread-makecurrent-*: Write the expected value for alpha

Ian Romanick idr at freedesktop.org
Mon Jan 28 15:35:20 PST 2013


From: Ian Romanick <ian.d.romanick at intel.com>

The tests would previously write 0.0 to the alpha and expect to read 1.0
back.  If the test got a visual without alpha (and it doesn't request
alpha), this would happen to work.  However, drivers are not required to
expose visuals without alpha, so the test might get an RGBA visual
afterall.

Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59738
---
 tests/glx/glx-multithread-makecurrent-1.c | 6 +++---
 tests/glx/glx-multithread-makecurrent-2.c | 4 ++--
 tests/glx/glx-multithread-makecurrent-3.c | 4 ++--
 tests/glx/glx-multithread-makecurrent-4.c | 4 ++--
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/tests/glx/glx-multithread-makecurrent-1.c b/tests/glx/glx-multithread-makecurrent-1.c
index 899d607..f8132db 100644
--- a/tests/glx/glx-multithread-makecurrent-1.c
+++ b/tests/glx/glx-multithread-makecurrent-1.c
@@ -63,7 +63,7 @@ thread1_func(void *arg)
 	pthread_mutex_unlock(&mutex);
 
 	get_lock_for_step(3);
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(10, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
@@ -82,7 +82,7 @@ thread2_func(void *arg)
 	pthread_mutex_unlock(&mutex);
 
 	get_lock_for_step(4);
-	glColor4f(0.0, 0.0, 1.0, 0.0);
+	glColor4f(0.0, 0.0, 1.0, 1.0);
 	piglit_draw_rect(30, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
@@ -132,7 +132,7 @@ draw(Display *dpy)
 
 	pthread_mutex_destroy(&mutex);
 
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(50, 10, 10, 10);
 
 	pass &= piglit_probe_rect_rgba( 0, 10, 10, 10, gray);
diff --git a/tests/glx/glx-multithread-makecurrent-2.c b/tests/glx/glx-multithread-makecurrent-2.c
index 8f1aa9b..1bb4519 100644
--- a/tests/glx/glx-multithread-makecurrent-2.c
+++ b/tests/glx/glx-multithread-makecurrent-2.c
@@ -63,7 +63,7 @@ thread1_func(void *arg)
 
 	get_lock_for_step(1);
 	glXMakeCurrent(dpy, win, ctx);
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(10, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
@@ -85,7 +85,7 @@ thread2_func(void *arg)
 {
 	get_lock_for_step(2);
 	glXMakeCurrent(dpy, win, ctx);
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(30, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
diff --git a/tests/glx/glx-multithread-makecurrent-3.c b/tests/glx/glx-multithread-makecurrent-3.c
index cf6cb16..a7df147 100644
--- a/tests/glx/glx-multithread-makecurrent-3.c
+++ b/tests/glx/glx-multithread-makecurrent-3.c
@@ -61,7 +61,7 @@ thread1_func(void *arg)
 {
 	get_lock_for_step(1);
 	glXMakeCurrent(dpy, win, ctx);
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(10, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
@@ -77,7 +77,7 @@ thread2_func(void *arg)
 {
 	get_lock_for_step(2);
 	glXMakeCurrent(dpy, win, ctx);
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(30, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
diff --git a/tests/glx/glx-multithread-makecurrent-4.c b/tests/glx/glx-multithread-makecurrent-4.c
index bd48f02..7ebeb5f 100644
--- a/tests/glx/glx-multithread-makecurrent-4.c
+++ b/tests/glx/glx-multithread-makecurrent-4.c
@@ -60,7 +60,7 @@ thread1_func(void *arg)
 {
 	get_lock_for_step(1);
 	glXMakeCurrent(dpy, win, ctx);
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(10, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
@@ -77,7 +77,7 @@ thread2_func(void *arg)
 {
 	get_lock_for_step(2);
 	glXMakeCurrent(dpy, win, ctx);
-	glColor4f(0.0, 1.0, 0.0, 0.0);
+	glColor4f(0.0, 1.0, 0.0, 1.0);
 	piglit_draw_rect(30, 10, 10, 10);
 	pthread_mutex_unlock(&mutex);
 
-- 
1.7.11.7



More information about the Piglit mailing list