[Piglit] [PATCH 1/3] android: piglit-vbo.cpp compile error

Tom Gall tom.gall at linaro.org
Mon Jan 28 17:11:09 PST 2013

Sure, but tell that to the compiler.

It is bad form to not have a return at the end of a function which is
supposed to return something.  The other way perhaps is just knock out
the default case and return that. Either way.

On Mon, Jan 28, 2013 at 7:01 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Jan 28, 2013 at 2:09 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> These changes seem innocuous enough.
>> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
> They are... but 2/3 and 3/3 are adding unreachable return statements
> after switches with a default case that asserts. Kind of bogus.


"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Tech Lead, Graphics Working Group | Linaro.org │ Open source software
for ARM SoCs
w) tom.gall att linaro.org
h) tom_gall att mac.com

More information about the Piglit mailing list