[Piglit] [PATCH] Test varying structs in GLSL ES 3.00.

Kenneth Graunke kenneth at whitecape.org
Tue Jan 29 11:54:43 PST 2013

On 01/21/2013 03:01 PM, Paul Berry wrote:
> diff --git a/tests/spec/glsl-es-3.00/execution/varying-struct-arrays.shader_test b/tests/spec/glsl-es-3.00/execution/varying-struct-arrays.shader_test

Seems like a good "mean" test...I'd hate to debug it, but worth having. 
  I didn't review the details.

> diff --git a/tests/spec/glsl-es-3.00/execution/varying-struct-basic.shader_test b/tests/spec/glsl-es-3.00/execution/varying-struct-basic.shader_test

Kind of big for a "basic" test, but definitely seems worth having.

> diff --git a/tests/spec/glsl-es-3.00/execution/varying-struct-centroid.c b/tests/spec/glsl-es-3.00/execution/varying-struct-centroid.c

This one looks fine.

> diff --git a/tests/spec/glsl-es-3.00/execution/varying-struct-copy-fs.shader_test b/tests/spec/glsl-es-3.00/execution/varying-struct-copy-fs.shader_test
> diff --git a/tests/spec/glsl-es-3.00/execution/varying-struct-copy-vs.shader_test b/tests/spec/glsl-es-3.00/execution/varying-struct-copy-vs.shader_test

Please, please, please split these into separate tests.   Debugging 
shaders that have 'subtests' with switch statements is generally a royal 
pain.  In particular, when I bring up a new hardware platform, I often 
have to compare Gen X assembly to Gen X+1 assembly.  The smaller the 
shader, the easier that is.

The individual subtests look reasonable.

> diff --git a/tests/spec/glsl-es-3.00/execution/varying-struct-interpolation.shader_test b/tests/spec/glsl-es-3.00/execution/varying-struct-interpolation.shader_test

This test seems reasonable.  It could be split, but it's simple enough 
that I wouldn't object either way.

More information about the Piglit mailing list