[Piglit] Fwd: [PATCH 1/1] RFC: add ability to report gl api supported by tests

Tom Gall tom.gall at linaro.org
Wed Jan 30 09:02:11 PST 2013

Why is this is a good patch to add?

In the not too distant future piglit tests will be able to be built
once and at runtime one cam choose to test against api family, IE GL,
GLES or both. I further assert that one will be able to specify what
context versions should be tested, IE GLES1, GLES2, GLES3, all.

This patch is a small part of these goals. When a testcase using this
code reports what it can do, it allows the python test harness to
decide if a testcase is a appropriate for running by asking it.

It keeps the capabilities of the test inside of the test source code
(or shader_test, or vertex, etc data files) instead of having to have
some extra specification information as part of say all.tests or in
some database or whatever).

The patch as currently written does not change the well worn paths of
how testcases are currently used.

Why JSON? python has good JSON support to reconstitute into a python object.

I will point out this could set the stage where all.tests could go
away. Instead, piglit could do a find looking for test binaries, data
files in standard locations, IE *shader_tests, *frag, *vert, etc,
query using this param, ending up with an organized python structure
of candidates, running based on what the user specified.

On Tue, Jan 29, 2013 at 6:09 PM, Eric Anholt <eric at anholt.net> wrote:
> Tom Gall <tom.gall at linaro.org> writes:
>> No feedback?
> I think what's missing is the explanation of "why do we want the tests
> to be able to print what apis they support?"


"Where's the kaboom!? There was supposed to be an earth-shattering
kaboom!" Marvin Martian
Tech Lead, Graphics Working Group | Linaro.org │ Open source software
for ARM SoCs
w) tom.gall att linaro.org
h) tom_gall att mac.com

More information about the Piglit mailing list