[Piglit] [PATCH] isbufferobj: Fail if glIsBuffer returns true before a glBindBuffer

Matt Turner mattst88 at gmail.com
Wed Jan 30 15:19:09 PST 2013


The spec's not vague, it's just stupid. glIsBuffer should return false
between the time a buffer name is generated and first bound.
---
 tests/general/isbufferobj.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/tests/general/isbufferobj.c b/tests/general/isbufferobj.c
index 3938d18..9657600 100644
--- a/tests/general/isbufferobj.c
+++ b/tests/general/isbufferobj.c
@@ -77,16 +77,10 @@ test(void)
       }
    }
 
-   /*
-    * The GL spec is vague here.  But the GL man pages say glIsBuffer should
-    * return false in this case.  Mesa and NVIDIA's driver return true.
-    * Generate a warning, not an error, if the driver doesn't follow the
-    * GL docs here.
-    */
    if (glIsBuffer(buffers[1])) {
       printf("%s: glIsBuffer(%u) returned true instead of false.\n",
              TestName, buffers[1]);
-      return PIGLIT_WARN;
+      return PIGLIT_FAIL;
    }
 
    return PIGLIT_PASS;
-- 
1.7.12.4



More information about the Piglit mailing list