[Piglit] [PATCH 11/26] glsl_parser_test.py: PEP8 compliance

Chad Versace chad.versace at linux.intel.com
Mon Jul 22 13:55:14 PDT 2013


On 07/10/2013 03:19 PM, Dylan Baker wrote:
> There is one non-compliance, a docstring comment that is longer than 79
> characters. However, this is a comment for a c-style file, and there is
> no way to break it without changing its meaning.
> ---
>   framework/glsl_parser_test.py | 90 ++++++++++++++++++++++++-------------------
>   1 file changed, 50 insertions(+), 40 deletions(-)


>           assert(self.config is not None)
> -        command = [
> -                path.join(testBinDir, 'glslparsertest'),
> -                self.__filepath,
> -                self.config.get('config', 'expect_result'),
> -                self.config.get('config', 'glsl_version')
> -                ]
> +        command = [path.join(testBinDir, 'glslparsertest'),
> +                   self.__filepath,
> +                   self.config.get('config', 'expect_result'),
> +                   self.config.get('config', 'glsl_version')]

As we discussed offline, the fixed-up array here does conform to
PEP8, as documented with this example from the PEP8 doc:

my_list = [
     1, 2, 3,
     4, 5, 6,
     ]

However, this patch includes a bunch of other awesome PEP8-ness, so
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>




More information about the Piglit mailing list