[Piglit] [PATCH 24/26] generate-cl-int-builtins.py: PEP8 compliance

[Aaron Watry]

On Mon, Jul 22, 2013 at 4:53 PM, Chad Versace
<chad.versace at linux.intel.com> wrote:
> On 07/10/2013 03:19 PM, Dylan Baker wrote:
>>
>> ---
>>   generated_tests/generate-cl-int-builtins.py | 690
>> ++++++++++++++--------------
>>   1 file changed, 351 insertions(+), 339 deletions(-)
>
>
>
>
>>       'max': {
>>           'arg_types': [T, T, T],
>>           'function_type': 'tss',
>>           'values': [
>> -            [92,   2, 12, MAX,   1, MAX, MIN, MAX, MAX, 0],
>> -            [92,   2, 12, MAX, MIN, MAX, MIN, MIN, MAX, 0],
>> -            [ 2, MIN,  4,   1,   1, MAX, MIN, MAX, MIN, 0]
>> +            [92, 2, 12, MAX, 1, MAX, MIN, MAX, MAX, 0],
>> +            [92, 2, 12, MAX, MIN, MAX, MIN, MIN, MAX, 0],
>> +            [2, MIN, 4, 1, 1, MAX, MIN, MAX, MIN, 0]
>>           ]
>>       },
>>       'min': {
>>           'arg_types': [T, T, T],
>>           'function_type': 'tss',
>>           'values': [
>> -            [ 2,  1, MIN,  4,   1, MIN, MAX, MIN, MIN, 0, MAX],
>> -            [92, 64,   2, 12, MAX, MIN, MAX, MIN, MIN, 0, MAX],
>> -            [ 2,  1, MIN,  4,   1,   1, MAX, MIN, MAX, 0, MAX]
>> +            [2, 1, MIN, 4, 1, MIN, MAX, MIN, MIN, 0, MAX],
>> +            [92, 64, 2, 12, MAX, MIN, MAX, MIN, MIN, 0, MAX],
>> +            [2, 1, MIN, 4, 1, 1, MAX, MIN, MAX, 0, MAX]
>>           ]
>>       },
>
>
>
>
>>       'rhadd': {
>> @@ -392,76 +399,77 @@ generic_tests = {
>>           'values': [
>>               [33, 1, 10],
>>               [32, 1, 12],
>> -            [33, 0,  8]
>> +            [33, 0, 8]
>>           ]
>>       },
>>       'rotate': {
>>           'arg_types': [T, T, T],
>>           'function_type': 'ttt',
>>           'values': [
>> -            [1, 8,    1,            2,             1],
>> -            [1, 1,    1,            1,             1],
>> -            [0, 3, SIZE, [add,SIZE,1], [mul,SIZE,10]]
>> +            [1, 8, 1, 2, 1],
>> +            [1, 1, 1, 1, 1],
>> +            [0, 3, SIZE, [add, SIZE, 1], [mul, SIZE, 10]]
>>           ]
>>       },
>>       'sub_sat': {
>>           'arg_types': [T, T, T],
>>           'function_type': 'ttt',
>>           'values': [
>> -            [1, 25, MAX,   0,   0, MIN,                 MIN],
>> -            [1, 57, MAX, MAX, MIN, MIN,         [div,MIN,2]],
>> -            [0, 32, MIN, MAX, MIN, MAX, [add,[div,MAX,2],1]]
>> +            [1, 25, MAX, 0, 0, MIN, MIN],
>> +            [1, 57, MAX, MAX, MIN, MIN, [div, MIN, 2]],
>> +            [0, 32, MIN, MAX, MIN, MAX, [add, [div, MAX, 2], 1]]
>>           ]
>
>
>
> I would prefer to preserve the formatting of the above tables, and
> some of the other similar tables in this file, but... meh. Aaron didn't
> object, so
>
> Reviewed-by: Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

Yeah, the previous formatting was nice, but I can understand adhering
to styling/formatting best practices/rules...  since it didn't mess
with the functionality and made automated code quality tools possibly
easier to use, I let it slide.

--Aaron

>
> _______________________________________________
> Piglit mailing list
> Piglit at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit