[Piglit] [PATCH 0/2] Second round of GLSL1.30-without-GL3 changes

Matt Turner mattst88 at gmail.com
Fri Jul 26 16:43:40 PDT 2013

On Wed, Jul 17, 2013 at 2:59 AM, Chris Forbes <chrisf at ijw.co.nz> wrote:
> This series relaxes the version requirement in the textureSize/texelFetch
> tests to allow GLSL 1.30 on GL2.1 + EXT_gpu_shader4, and adjusts gl.spec
> to assign all the EXT_gpu_shader4 functions to that extension, rather than
> having half of them assigned to NV_* extensions.

Patch 1 is Reviewed-by: Matt Turner <mattst88 at gmail.com>

> The second patch might be doing it completely wrong -- is there a better way?
> I couldn't find a precedent in gl.spec where an extension function is exposed
> by multiple extensions.

The changes in the second look good.

I think we already have local changes to gl.spec, but I'd probably
like someone like Paul to just ack it.

If he says it's okay, then have a my reviewed-by on it, since the
changes themselves look right.

> With this series, i965 Gen5 is up to 1944/2004 GLSL 1.30 piglits with
> GLSL 1.30 and EXT_gpu_shader4 enabled.


More information about the Piglit mailing list